runtime: Route logger records according to file logging

Align stderr routing with log_to_file so normal records are file-only when enabled and only errors reach stderr when disabled. Update observability tests and contracts to document the stream behavior while preserving user-facing diagnostics and command payload routing.

Co-authored-by: SCE <sce@crocoder.dev>

Author: stefanskoricdev

cli/src/services/app_support.rs

@@ -334,7 +334,7 @@ mod tests {
 
         let rendered = String::from_utf8(stderr).expect("stderr is valid utf8");
         let redacted_message =
-            services::security::redact_sensitive_text(&UserError::NotAuthenticated.message());
+            services::security::redact_sensitive_text(UserError::NotAuthenticated.message());
         assert!(rendered.contains(&redacted_message));
     }
 

cli/src/services/error.rs

@@ -224,10 +224,6 @@ mod tests {
             UserError::NotGitRepository.key(),
             "setup.not_git_repository"
         );
-        assert_eq!(
-            UserError::NotGitRepository.message(),
-            "This directory is not a Git repository. Run `git init`, then rerun `sce setup`."
-        );
         assert_eq!(error.to_string(), UserError::NotGitRepository.message());
     }
 

cli/src/services/observability.rs

@@ -306,7 +306,7 @@ fn cli_error_fields(error: &CliError) -> Vec<(&'static str, String)> {
 }
 
 fn should_emit_to_stderr(level: LogLevel, log_to_file: bool) -> bool {
-    level != LogLevel::Error || !log_to_file
+    level == LogLevel::Error && !log_to_file
 }
 
 fn validate_log_dir(value: &str) -> Result<()> {
@@ -752,10 +752,17 @@ mod tests {
     }
 
     #[test]
-    fn non_error_records_remain_on_stderr_when_file_logging_is_enabled() {
-        assert!(should_emit_to_stderr(LogLevel::Warn, true));
-        assert!(should_emit_to_stderr(LogLevel::Info, true));
-        assert!(should_emit_to_stderr(LogLevel::Debug, true));
+    fn non_error_records_do_not_route_to_stderr_when_file_logging_is_enabled() {
+        assert!(!should_emit_to_stderr(LogLevel::Warn, true));
+        assert!(!should_emit_to_stderr(LogLevel::Info, true));
+        assert!(!should_emit_to_stderr(LogLevel::Debug, true));
+    }
+
+    #[test]
+    fn non_error_records_do_not_route_to_stderr_when_file_logging_is_disabled() {
+        assert!(!should_emit_to_stderr(LogLevel::Warn, false));
+        assert!(!should_emit_to_stderr(LogLevel::Info, false));
+        assert!(!should_emit_to_stderr(LogLevel::Debug, false));
     }
 
     #[test]

cli/src/services/setup/command.rs

@@ -173,22 +173,3 @@ fn setup_required_hooks_outcome_from_lifecycle(
             .collect(),
     }
 }
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-    use std::time::{SystemTime, UNIX_EPOCH};
-
-    fn unique_temp_dir(label: &str) -> std::path::PathBuf {
-        let nonce = SystemTime::now()
-            .duration_since(UNIX_EPOCH)
-            .expect("system time should be after Unix epoch")
-            .as_nanos();
-        let directory = std::env::temp_dir().join(format!(
-            "sce-setup-command-{label}-{}-{nonce}",
-            std::process::id()
-        ));
-        std::fs::create_dir_all(&directory).expect("create temporary directory");
-        directory
-    }
-}