Asset Image Editor throws JavaScript console errors on Craft Cloud environments

[jamesmacwhite]

Description

Under a Craft Cloud environment the Asset Image Editor fails to load properly and throws the following errors in the web browser developer console:

AssetImageEditor.js:322 Uncaught TypeError: e.image.getHeight is not a function
AssetImageEditor.js:515 Uncaught TypeError: Cannot read properties of null (reading 'width')
AssetImageEditor.js:515 Uncaught TypeError: Cannot read properties of null (reading 'width')

This causes either the image to partially load or not load at all in the editor with a spinner.

The same asset can be edited on a local development environment that isn't Craft Cloud without any issues.

Possibly related to the recent Image transformer changes with Cloudflare.

Steps to reproduce

1. Select an asset under Craft Cloud storage on a Craft Cloud environment
2. Hover over the thumb image preview for the Edit Image option
3. The Asset Image Editor modal will open but throw JavaScript errors related to the asset regard the width property.

Possibly also related CLOUD-637

Additional info

• craftcms/cms version: 5.9.20
• craftcms/cloud version: 3.0.9
• PHP version: 8.4
• Database driver & version: MySQL

[linear]

CLOUD-638

[jamesmacwhite]

Note this also happens on storage types other the Craft Cloud e.g. Standard S3 buckets.

[timkelty]

@jamesmacwhite planning a release today to address this a couple other reported issues.

[jamesmacwhite]

Great news, thank you!

[timkelty]

@jamesmacwhite I wasn't able to consistently reproduce this, but I think #151 should fix it.

If possible, can you share more specifics in a support ticket? eg specific environment, asset.

[jamesmacwhite]

@timkelty Thanks! I'll deploy 3.x-dev onto our staging environment and re-test the Asset Editor, if there are still issues I'll email support@craft.cloid with the details.

[jamesmacwhite]

This is still broken I'm afraid, specifically on Craft Cloud. I'll send in a support request.

[jamesmacwhite]

Omg, sorry, ignore this. There's a browser extension potentially modifying something and causing the breakage, for some reason it is triggered not on dev but is on another environment. I've just opened an incognito window and the Asset Editor works fine in incognito.

I'll trace what the extension is.

[jamesmacwhite]

For info, the issue is logged on the main Craft CMS repo: craftcms/cms#18730

While the AssetImageEditor.js file throws the exception it is because of the Bugherd extension so I'm reaching out to them as well. The reason why this doesn't happen on local but does on Craft Cloud, is because the configured sites under the Bugherd project does not include local dev URLs, so it looks like it was Craft Cloud, but that's because all Craft Cloud environments are configured as site URLs in Bugherd!

Sorry about chasing a ghost!

[timkelty]

To clarify – does it work for you even with without the PR?

[jamesmacwhite]

Yes, the asset editor breaking is due to the Bugherd extension. Disabling it doesn't cause the JS error. Apologies