Fix #14189 FP useInitializationList when members are assigned (danmar#7908)

Author: chrchr-github

lib/checkclass.cpp

@@ -1226,6 +1226,10 @@ void CheckClass::initializationListUsage()
                         allowed = false;
                         return ChildrenToVisit::done;
                     }
+                    if (var2->isLocal() && isVariableChanged(var2->nameToken(), previousBeforeAstLeftmostLeaf(tok), var2->declarationId(), /*globalvar*/ false, *mSettings)) {
+                        allowed = false;
+                        return ChildrenToVisit::done;
+                    }
                 } else if (tok2->str() == "this") { // 'this' instance is not completely constructed in initialization list
                     allowed = false;
                     return ChildrenToVisit::done;

test/testclass.cpp

@@ -8119,6 +8119,21 @@ class TestClass : public TestFixture {
                                      "    std::string st;\n"
                                      "};");
         ASSERT_EQUALS("", errout_str());
+
+        checkInitializationListUsage("struct S {\n" // #14189
+                                     "    S() {}\n"
+                                     "    int i{};\n"
+                                     "};\n"
+                                     "struct T { explicit T(const S&); };\n"
+                                     "class C {\n"
+                                     "    C() {\n"
+                                     "        S s;\n"
+                                     "        s.i = 1;\n"
+                                     "        p = std::make_unique<T>(s);\n"
+                                     "    }\n"
+                                     "    std::unique_ptr<T> p;\n"
+                                     "};");
+        ASSERT_EQUALS("", errout_str());
     }