fix #14010: False constParameterReference ignoring call with designated-initializer & #14018: Invalid AST for function call with designated initializer (danmar#7673)

Author: ludviggunne

lib/tokenlist.cpp

@@ -831,7 +831,7 @@ static void compileTerm(Token *&tok, AST_state& state)
         } else if ((state.cpp && iscpp11init(tok)) || Token::simpleMatch(tok->previous(), "] {")) {
             Token *const end = tok->link();
             if (state.op.empty() || Token::Match(tok->previous(), "[{,]") || Token::Match(tok->tokAt(-2), "%name% (")) {
-                if (Token::Match(tok->tokAt(-1), "!!, { . %name% =|{")) {
+                if (Token::Match(tok->tokAt(-1), "!!, { . %name% =|{") && !Token::simpleMatch(tok->tokAt(-1), "(")) {
                     const int inArrayAssignment = state.inArrayAssignment;
                     state.inArrayAssignment = 1;
                     compileBinOp(tok, state, compileExpression);

test/testother.cpp

@@ -3902,6 +3902,9 @@ class TestOther : public TestFixture {
                       "[test.cpp:7:10]: (style) Parameter 't' can be declared as reference to const [constParameterReference]\n"
                       "[test.cpp:10:25]: (style) Parameter 'v' can be declared as reference to const [constParameterReference]\n",
                       errout_str());
+
+        check("void push(V& v) { v.push_back({ .x = 1 }); }"); // #14010
+        ASSERT_EQUALS("", errout_str());
     }
 
     void constParameterCallback() {

test/testtokenize.cpp

@@ -403,6 +403,7 @@ class TestTokenizer : public TestFixture {
         TEST_CASE(astvardecl);
         TEST_CASE(astnewscoped);
         TEST_CASE(astdecltypescope);
+        TEST_CASE(astdesignatedinit);
 
         TEST_CASE(startOfExecutableScope);
 
@@ -7176,6 +7177,10 @@ class TestTokenizer : public TestFixture {
         ASSERT_EQUALS("sizedecltypethism_P.(XSize::::{", testAst("size { decltype(this->m_P)::X::Size };"));
     }
 
+    void astdesignatedinit() {
+        ASSERT_EQUALS("(( f ({ (= (. x) 1)))", testAst("f({ .x = 1 });", AstStyle::Z3));
+    }
+
 #define isStartOfExecutableScope(offset, code) isStartOfExecutableScope_(offset, code, __FILE__, __LINE__)
     template<size_t size>
     bool isStartOfExecutableScope_(int offset, const char (&code)[size], const char* file, int line) {