Fix 9834: False negative: No invalidContainer when using reference to member (danmar#7461)

Author: pfultz2

lib/valueflow.cpp

@@ -1789,8 +1789,8 @@ static std::vector<ValueFlow::LifetimeToken> getLifetimeTokens(const Token* tok,
                     false);
             }
         } else {
-            return ValueFlow::LifetimeToken::setAddressOf(getLifetimeTokens(vartok, escape, std::move(errorPath), pred, settings, depth - 1),
-                                                          !(astIsContainer(vartok) && Token::simpleMatch(vartok->astParent(), "[")));
+            return ValueFlow::LifetimeToken::setAddressOf(
+                getLifetimeTokens(vartok, escape, std::move(errorPath), pred, settings, depth - 1), false);
         }
     } else if (Token::simpleMatch(tok, "{") && getArgumentStart(tok) &&
                !Token::simpleMatch(getArgumentStart(tok), ",") && getArgumentStart(tok)->valueType()) {

test/teststl.cpp

@@ -6475,6 +6475,22 @@ class TestStl : public TestFixture {
         ASSERT_EQUALS(
             "[test.cpp:1] -> [test.cpp:2] -> [test.cpp:1] -> [test.cpp:2] -> [test.cpp:2] -> [test.cpp:3] -> [test.cpp:1] -> [test.cpp:4]: (error) Using pointer to local variable 'v' that may be invalid.\n",
             errout_str());
+
+        // #9834
+        check("struct CJ {\n"
+              "    std::string m_string1 = \"hello\";\n"
+              "};\n"
+              "void f() {\n"
+              "    std::vector<CJ> vec1;\n"
+              "    vec1.push_back(CJ());\n"
+              "    auto& a_ref = vec1.at(0).m_string1;\n"
+              "    vec1.clear();\n"
+              "    std::cout << a_ref << std::endl;\n"
+              "}\n",
+              dinit(CheckOptions, $.inconclusive = true));
+        ASSERT_EQUALS(
+            "[test.cpp:7] -> [test.cpp:7] -> [test.cpp:8] -> [test.cpp:9]: (error) Reference to vec1 that may be invalid.\n",
+            errout_str());
     }
 
     void invalidContainerLoop() {