Skip to content

Un-poped sign conversion warning #478

Description

@mborland

Headers disable -Wsign-conversion for the rest of the TU, which can have impacts on user-side by silencing relevant/important warnings.

Files:

detail/uint128_imp.hpp:403-408 pushes and never pops.
detail/int128_imp.hpp (with Clang) also nets one extra push: pushes at the line 445 (-Wsign-conversion, -Wsign-compare) and 2151 (-Wassume), single pop at line 2371.

Metadata

Metadata

Assignees

Labels

Boost ReviewFeedback from the review period including pre- and post- on the MLBugSomething isn't working

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions