From 744ab78589f47d9a5e9056102596a536a3b5b60b Mon Sep 17 00:00:00 2001 From: Michael Vandeberg Date: Fri, 23 Jan 2026 16:03:30 -0700 Subject: [PATCH] Move thread_name to boost/capy/test --- .../boost/capy/{detail => test}/thread_name.hpp | 6 ++---- src/ex/thread_pool.cpp | 4 ++-- src/{detail => test}/thread_name.cpp | 4 +--- test/unit/thread_name.cpp | 14 +++++++------- 4 files changed, 12 insertions(+), 16 deletions(-) rename include/boost/capy/{detail => test}/thread_name.hpp (91%) rename src/{detail => test}/thread_name.cpp (97%) diff --git a/include/boost/capy/detail/thread_name.hpp b/include/boost/capy/test/thread_name.hpp similarity index 91% rename from include/boost/capy/detail/thread_name.hpp rename to include/boost/capy/test/thread_name.hpp index 0310571e..4e3f489a 100644 --- a/include/boost/capy/detail/thread_name.hpp +++ b/include/boost/capy/test/thread_name.hpp @@ -7,8 +7,8 @@ // Official repository: https://github.com/cppalliance/capy // -#ifndef BOOST_CAPY_DETAIL_THREAD_NAME_HPP -#define BOOST_CAPY_DETAIL_THREAD_NAME_HPP +#ifndef BOOST_CAPY_TEST_THREAD_NAME_HPP +#define BOOST_CAPY_TEST_THREAD_NAME_HPP #include @@ -27,7 +27,6 @@ namespace boost { namespace capy { -namespace detail { /** Set the name of the current thread for debugging purposes. @@ -42,7 +41,6 @@ BOOST_CAPY_DECL void set_current_thread_name(char const* name) noexcept; -} // detail } // capy } // boost diff --git a/src/ex/thread_pool.cpp b/src/ex/thread_pool.cpp index 60eef636..63800ac9 100644 --- a/src/ex/thread_pool.cpp +++ b/src/ex/thread_pool.cpp @@ -10,7 +10,7 @@ #include #include -#include +#include #include #include #include @@ -134,7 +134,7 @@ class thread_pool::impl // Build name; set_current_thread_name truncates to platform limits. char name[16]; std::snprintf(name, sizeof(name), "%s%zu", thread_name_prefix_, index); - detail::set_current_thread_name(name); + set_current_thread_name(name); for(;;) { diff --git a/src/detail/thread_name.cpp b/src/test/thread_name.cpp similarity index 97% rename from src/detail/thread_name.cpp rename to src/test/thread_name.cpp index 5b62cb7f..8d7a82be 100644 --- a/src/detail/thread_name.cpp +++ b/src/test/thread_name.cpp @@ -7,7 +7,7 @@ // Official repository: https://github.com/cppalliance/capy // -#include +#include #if defined(_WIN32) @@ -45,7 +45,6 @@ namespace boost { namespace capy { -namespace detail { void set_current_thread_name(char const* name) noexcept @@ -97,6 +96,5 @@ set_current_thread_name(char const* name) noexcept #endif } -} // detail } // capy } // boost diff --git a/test/unit/thread_name.cpp b/test/unit/thread_name.cpp index 14836f1b..1f96e7fd 100644 --- a/test/unit/thread_name.cpp +++ b/test/unit/thread_name.cpp @@ -8,7 +8,7 @@ // // Test that header file is self-contained. -#include +#include #include "test_helpers.hpp" @@ -21,14 +21,14 @@ struct thread_name_test testSetName() { #if defined(BOOST_CAPY_TEST_CAN_GET_THREAD_NAME) - detail::set_current_thread_name("test-thread"); + set_current_thread_name("test-thread"); BOOST_TEST(check_thread_name("test-thread")); - detail::set_current_thread_name("capy-pool-0"); + set_current_thread_name("capy-pool-0"); BOOST_TEST(check_thread_name("capy-pool-0")); // Long name is truncated to 15 chars on Linux/FreeBSD/NetBSD - detail::set_current_thread_name( + set_current_thread_name( "this-is-a-very-long-thread-name-that-exceeds-limits"); #if defined(__linux__) || defined(__FreeBSD__) || defined(__NetBSD__) BOOST_TEST(check_thread_name("this-is-a-very-")); @@ -43,7 +43,7 @@ struct thread_name_test #endif // Test macOS 63-char limit specifically - detail::set_current_thread_name( + set_current_thread_name( "0123456789012345678901234567890123456789012345678901234567890123456789"); #if defined(__APPLE__) // Truncated to 63 chars @@ -53,14 +53,14 @@ struct thread_name_test #if defined(_WIN32) // Windows UTF-8 support (simple ASCII subset) - detail::set_current_thread_name("worker-thread-1"); + set_current_thread_name("worker-thread-1"); BOOST_TEST(check_thread_name("worker-thread-1")); #endif #endif // BOOST_CAPY_TEST_CAN_GET_THREAD_NAME // Empty string should not crash (but we don't verify the result // since some platforms may not support clearing thread names) - detail::set_current_thread_name(""); + set_current_thread_name(""); } void