Skip to content

Commit d4843b9

Browse files
author
rakeshAlgo
committed
Fix esLiint error for landing page functionality
1 parent b8378a7 commit d4843b9

File tree

4 files changed

+84
-110
lines changed

4 files changed

+84
-110
lines changed

‎src/css/landing-page.css‎

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
margin-right: 8px;
5858
}
5959

60-
.doc.landing-page-doc .filter-info{
60+
.doc.landing-page-doc .filter-info {
6161
margin-top: 15px;
6262
margin-bottom: 10px;
6363
display: inline-block;
@@ -147,7 +147,7 @@
147147

148148
.doc.landing-page-doc ul li {
149149
list-style: none;
150-
margin:0 0 8px;
150+
margin: 0 0 8px;
151151
font-size: 1rem;
152152
font-family: "Open Sans", sans-serif;
153153
color: var(--color-brand-black);
@@ -188,28 +188,27 @@
188188
text-align: justify;
189189
}
190190

191-
.card-row.two-column-row .column:not(.data-filter-column):nth-child(odd){
191+
.card-row.two-column-row .column:not(.data-filter-column):nth-child(odd) {
192192
padding-right: 40px;
193193
}
194194

195-
.card-row.two-column-row .column:not(.data-filter-column):nth-child(even){
195+
.card-row.two-column-row .column:not(.data-filter-column):nth-child(even) {
196196
padding-left: 40px;
197197
}
198198

199-
200199
.card-row.two-column-row .column.data-filter-column.even {
201200
padding-left: 40px;
202201
}
202+
203203
.card-row.two-column-row .column.data-filter-column.odd {
204204
padding-right: 40px;
205205
}
206206

207-
208-
209-
.card-row.two-column-row .column.data-filter-column.hide{
207+
.card-row.two-column-row .column.data-filter-column.hide {
210208
display: none;
211209
}
212-
.hide{
210+
211+
.hide {
213212
display: none;
214213
}
215214

@@ -263,12 +262,12 @@
263262
display: flex;
264263
align-items: center;
265264
text-decoration: none;
266-
267265
}
268266

269267
.nav.tutorials-filter ul li a:hover {
270268
color: var(--color-brand-blue);
271269
}
270+
272271
.nav.tutorials-filter ul li a.active .arrow.arrow-right {
273272
transform: rotate(90deg);
274273
}

‎src/js/01-nav.js‎

Lines changed: 7 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@
7979
var navMenuControl
8080
if (document.querySelector('.main-nav-parent')) {
8181
navMenuControl = document.querySelector('.main-nav-parent')
82-
8382
navMenuControl.addEventListener('click', function () {
8483
// navWrap.style.display = 'none'
8584
for (var i = 0; i < navItems.length; i++) {
@@ -89,9 +88,8 @@
8988
this.style.display = 'none'
9089
})
9190
}
92-
9391
// Toggle class
94-
function toggleActive(e) {
92+
function toggleActive (e) {
9593
if (this.getAttribute('data-depth') === '1') {
9694
var otherNavs = document.querySelectorAll('.nav-item[data-depth="0"]:not(.is-active)')
9795
console.log(otherNavs)
@@ -102,22 +100,8 @@
102100
this.classList.toggle('is-active')
103101
}
104102

105-
// function addActive (e) {
106-
// removeClasses(e)
107-
// this.classList.add('is-active')
108-
// concealEvent(e)
109-
// }
110-
111103
var navItems = document.querySelectorAll('.nav .nav-item')
112-
113-
// function removeClasses (e) {
114-
// for (var i = 0; i < navItems.length; i++) {
115-
// navItems[i].classList.remove('is-active')
116-
// }
117-
// concealEvent(e)
118-
// }
119-
120-
function revealNav(e) {
104+
function revealNav (e) {
121105
if (nav.classList.contains('is-active')) return hideNav(e)
122106
document.documentElement.classList.add('is-clipped--nav')
123107
nav.classList.add('is-active')
@@ -126,7 +110,7 @@
126110
concealEvent(e) // NOTE don't let event get picked up by window click listener
127111
}
128112

129-
function hideNav(e) {
113+
function hideNav (e) {
130114
if (e.which === 3 || e.button === 2) return
131115
document.documentElement.classList.remove('is-clipped--nav')
132116
nav.classList.remove('is-active')
@@ -135,11 +119,11 @@
135119
concealEvent(e) // NOTE don't let event get picked up by window click listener
136120
}
137121

138-
function find(selector, from) {
122+
function find (selector, from) {
139123
return [].slice.call((from || document).querySelectorAll(selector))
140124
}
141125

142-
function findAncestorWithClass(className, from, scope) {
126+
function findAncestorWithClass (className, from, scope) {
143127
if ((from = from.parentNode) !== scope) {
144128
if (from.classList.contains(className)) {
145129
return from
@@ -149,14 +133,14 @@
149133
}
150134
}
151135

152-
function findNextElement(from, el) {
136+
function findNextElement (from, el) {
153137
if ((el = from.nextElementSibling)) return el
154138
el = from
155139
while ((el = el.nextSibling) && el.nodeType !== 1);
156140
return el
157141
}
158142

159-
function concealEvent(e) {
143+
function concealEvent (e) {
160144
e.stopPropagation()
161145
}
162146
})()

‎src/js/06-page-rating.js‎

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,18 +17,16 @@
1717
var anyFeedbackBtn = document.querySelector('.any-feedback-btn')
1818
// for config
1919

20-
21-
if(document.querySelector('.is-this-helpful-box')){
22-
var yesBtnData = helpYesBtn.dataset
23-
var noBtnData = helpNoBtn.dataset
20+
if (document.querySelector('.is-this-helpful-box')) {
21+
var yesBtnData = helpYesBtn.dataset
22+
var noBtnData = helpNoBtn.dataset
2423
helpYesBtn.addEventListener('click', function (e) {
2524
// dialogBox.style.display = 'block'
2625
this.classList.add('active')
2726
helpNoBtn.classList.remove('active')
2827
console.log(yesBtnData, 16)
2928
})
3029

31-
3230
helpNoBtn.addEventListener('click', function (e) {
3331
// dialogBox.style.display = 'block'
3432
this.classList.add('active')
@@ -64,7 +62,4 @@
6462
feedbackModal.classList.remove('show')
6563
})
6664
}
67-
68-
69-
7065
})()

‎src/js/10-landing-page-nav.js‎

Lines changed: 65 additions & 69 deletions
Original file line numberDiff line numberDiff line change
@@ -5,85 +5,81 @@
55
$(this).toggleClass('active')
66
$(this).next('.sub-menu').slideToggle(10)
77
})
8-
9-
// add class even odd
10-
var $allData = $('.data-filter-column')
11-
for(var i= 0; i < $allData.length; i++) {
12-
console.log(i, 445, $allData[i])
13-
if((i % 2) == 1) {
8+
// add class even odd
9+
var $allData = $('.data-filter-column')
10+
for (var i = 0; i < $allData.length; i++) {
11+
console.log(i, 445, $allData[i])
12+
if ((i % 2) === 1) {
1413
$allData[i].classList.add('even')
15-
}else{
16-
$allData[i].classList.add('odd')
14+
} else {
15+
$allData[i].classList.add('odd')
16+
}
1717
}
18-
}
1918

20-
// for filter menu
21-
var $filterMenuCheckboxes = $('input[type="checkbox"]')
22-
$filterMenuCheckboxes.on('change', function () {
23-
var selectedFiltersData = {}
24-
$filterMenuCheckboxes.filter(':checked').each(function () {
25-
if (!selectedFiltersData.hasOwnProperty(this.name)) {
26-
selectedFiltersData[this.name] = []
27-
}
19+
// for filter menu
20+
var $filterMenuCheckboxes = $('input[type="checkbox"]')
21+
$filterMenuCheckboxes.on('change', function () {
22+
var selectedFiltersData = {}
23+
$filterMenuCheckboxes.filter(':checked').each(function () {
24+
if (!Object.prototype.hasOwnProperty.call(selectedFiltersData, this.name)) {
25+
selectedFiltersData[this.name] = []
26+
}
2827
// console.log(selectedFiltersData, 27)
29-
selectedFiltersData[this.name].push(this.value.toLowerCase())
30-
})
31-
// create a collection containing all of the filterable elements
32-
var $filteredResultsData = $('.data-filter-column')
33-
// loop over the selected filter name -> (array) values pairs
34-
$filteredResultsData.removeClass('even')
35-
$filteredResultsData.removeClass('odd')
36-
$.each(selectedFiltersData, function (name, filterValues) {
37-
// filter each .data-filter-column element
38-
$filteredResultsData = $filteredResultsData.filter(function () {
39-
var matched = false,
40-
currentFilterValues = $(this).find('.sub-heading').data('category').toLowerCase().split(' ')
41-
42-
28+
selectedFiltersData[this.name].push(this.value.toLowerCase())
29+
})
30+
// create a collection containing all of the filterable elements
31+
var $filteredResultsData = $('.data-filter-column')
32+
// loop over the selected filter name -> (array) values pairs
33+
$filteredResultsData.removeClass('even')
34+
$filteredResultsData.removeClass('odd')
35+
$.each(selectedFiltersData, function (name, filterValues) {
36+
// filter each .data-filter-column element
37+
$filteredResultsData = $filteredResultsData.filter(function () {
38+
var matched = false
39+
var currentFilterValues = $(this).find('.sub-heading').data('category').toLowerCase().split(' ')
4340

44-
$.each(currentFilterValues, function (_, currentFilterValue) {
41+
$.each(currentFilterValues, function (_, currentFilterValue) {
4542
// console.log('enter', currentFilterValues, currentFilterValue)
46-
if ($.inArray(currentFilterValue, filterValues) != -1) {
47-
console.log('true', currentFilterValue, filterValues)
48-
matched = true
49-
return false
50-
}
51-
})
52-
// if matched is true the current .data-filter-column element is returned
53-
return matched
43+
if ($.inArray(currentFilterValue, filterValues) !== -1) {
44+
console.log('true', currentFilterValue, filterValues)
45+
matched = true
46+
return false
47+
}
5448
})
49+
// if matched is true the current .data-filter-column element is returned
50+
return matched
5551
})
56-
52+
})
5753

5854
$('.data-filter-column').addClass('hide').filter($filteredResultsData).addClass('show').removeClass('hide')
59-
// add class for data-filter-column
60-
for(var i= 0; i < $filteredResultsData.length; i++) {
61-
console.log(i, 445, $filteredResultsData[i])
62-
if((i % 2) == 1) {
63-
$filteredResultsData[i].classList.add('even')
64-
}else{
65-
$filteredResultsData[i].classList.add('odd')
66-
}
67-
}
68-
// reset all check mark
69-
$('#clearALLBtn').click(function (event) {
70-
selectedFiltersData = []
71-
$('.data-filter-column').removeClass('hide').removeClass('show').removeClass('odd').removeClass('even')
72-
var inputs = $('.check-mark')
73-
for (var i = 0; i < inputs.length; i++) {
74-
inputs[i].checked = false
75-
}
76-
for(var i= 0; i < $allData.length; i++) {
77-
console.log(i, 445, $allData[i])
78-
// $allData[i].classList.remove('even')
79-
// $allData[i].classList.remove('odd')
80-
if((i % 2) == 1) {
81-
$allData[i].classList.add('even')
82-
}else{
83-
$allData[i].classList.add('odd')
84-
}
55+
// add class for data-filter-column
56+
for (var i = 0; i < $filteredResultsData.length; i++) {
57+
console.log(i, 445, $filteredResultsData[i])
58+
if ((i % 2) === 1) {
59+
$filteredResultsData[i].classList.add('even')
60+
} else {
61+
$filteredResultsData[i].classList.add('odd')
62+
}
63+
}
64+
// reset all check mark
65+
$('#clearALLBtn').click(function (event) {
66+
selectedFiltersData = []
67+
$('.data-filter-column').removeClass('hide').removeClass('show').removeClass('odd').removeClass('even')
68+
var inputs = $('.check-mark')
69+
for (var j = 0; j < inputs.length; j++) {
70+
inputs[j].checked = false
71+
}
72+
for (var i = 0; i < $allData.length; i++) {
73+
console.log(i, 445, $allData[i])
74+
// $allData[i].classList.remove('even')
75+
// $allData[i].classList.remove('odd')
76+
if ((i % 2) === 1) {
77+
$allData[i].classList.add('even')
78+
} else {
79+
$allData[i].classList.add('odd')
8580
}
86-
87-
})
81+
}
8882
})
83+
})
84+
/*eslint-env jquery*/
8985
})(jQuery)

0 commit comments

Comments
 (0)