Skip to content

Commit 05e1a3f

Browse files
author
rakeshAlgo
committed
UI issues fixes for table paragraph spacing , h1 label alignment, fix font size of h4 and h5
1 parent 10f176f commit 05e1a3f

File tree

4 files changed

+39
-9
lines changed

4 files changed

+39
-9
lines changed

src/css/doc.css

Lines changed: 21 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,17 +25,22 @@
2525
margin: 2.5rem 0 0;
2626
}
2727

28+
.page-heading-title {
29+
display: flex;
30+
align-items: center;
31+
flex-wrap: wrap;
32+
}
33+
2834
.doc h1.page {
2935
font-size: var(--heading-h1);
36+
line-height: 50px;
3037
margin-top: 0;
38+
margin-right: var(--base-space);
3139
display: inline-block;
3240
}
3341

3442
.doc h1.page + .labels {
3543
display: inline-block;
36-
position: relative;
37-
top: -5px;
38-
margin-left: var(--base-space);
3944
}
4045

4146
.doc h2 {
@@ -64,7 +69,7 @@
6469
}
6570

6671
.doc h5 {
67-
font-size: var(--heading-h4);
72+
font-size: var(--heading-h5);
6873
}
6974

7075
.doc h1 > a.anchor,
@@ -77,10 +82,20 @@
7782
position: absolute;
7883
text-decoration: none;
7984
width: 3ex;
80-
margin-left: -2.5ex;
85+
margin-left: -2.75ex;
8186
visibility: hidden;
8287
text-align: center;
88+
transform: scale(0.85);
89+
}
90+
91+
.doc h1 > a.anchor {
92+
transform: scale(0.65);
93+
margin-left: -2.25ex;
94+
}
95+
96+
.doc h2 > a.anchor {
8397
transform: scale(0.75);
98+
margin-left: -2.5ex;
8499
}
85100

86101
.doc h1:hover a.anchor,
@@ -1015,6 +1030,7 @@ table.tableblock pre code.language-bash.hljs {
10151030
font-size: var(--heading-h1-sm);
10161031
margin-bottom: 10px;
10171032
display: block;
1033+
line-height: 46px;
10181034
}
10191035

10201036
.doc h2 {

src/css/table.css

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ table.tableblock > tbody th {
5858
display: block;
5959
border-bottom: 1px solid var(--color-brand-gray8);
6060
padding-left: var(--base-small-space);
61-
padding-top: var(--base-space);
61+
/* padding-top: var(--base-space); */
6262
padding-bottom: var(--base-space);
6363
}
6464

@@ -69,10 +69,14 @@ table.tableblock tbody td p {
6969
font-weight: var(--weight-medium);
7070
}
7171

72-
table.tableblock .content .paragraph,
72+
table.tableblock tbody td.tableblock p.tableblock {
73+
margin-top: 1rem;
74+
}
75+
76+
/* table.tableblock .content .paragraph,
7377
table.tableblock .content .ulist {
7478
margin-top: 0;
75-
}
79+
} */
7680

7781
/* table.tableblock tr:nth-child(odd) {
7882
background: rgba(0, 0, 0, 0.07);g29
@@ -105,6 +109,12 @@ table.table-tutorial tr td:last-child {
105109
background-color: var(--color-brand-gray7);
106110
}
107111

112+
.tableblock thead a,
113+
.tableblock tbody a,
114+
.tableblock p {
115+
font-family: inherit;
116+
}
117+
108118
/* Responsive css */
109119

110120
@media screen and (min-width: 768px) {
@@ -147,6 +157,7 @@ table.table-tutorial tr td:last-child {
147157
table.tableblock tbody td,
148158
table.tableblock > tbody th {
149159
display: table-cell;
160+
min-width: 5rem;
150161
}
151162

152163
table.tableblock td,

src/css/vars.css

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,8 @@
110110
--heading-h1: 2.5rem; /* ~40px */
111111
--heading-h2: 2rem; /* ~32px */
112112
--heading-h3: 1.5rem; /* ~24px */
113-
--heading-h4: 1rem; /* ~16px */
113+
--heading-h4: 1.25rem; /* ~20px */
114+
--heading-h5: var(--font-base); /* ~16px */
114115

115116
/* line height */
116117
--line-height-body: 160%;

src/partials/article.hbs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
<article class="doc">
22
{{#if page.title}}
3+
<div class="page-heading-title">
34
<h1 class="page">{{{page.title}}}</h1>
45
{{> labels}}
6+
</div>
57
{{/if}}
68
{{> contributor-bot}}
79
{{{page.contents}}}

0 commit comments

Comments
 (0)