Skip to content

Commit b5f0c5a

Browse files
fix: initialize results and failed_count before directory check in import functions (#178)
All _import_* functions now initialize results=[] and failed_count=0 before checking if directory exists. This prevents UnboundLocalError when importing partial exports that don't include all resource types. Fixed functions: - _import_catalog: Added results=[] and failed_count=0 - _import_plugins: Added results=[] and failed_count=0 - _import_scorecards: Added results=[] and failed_count=0 - _import_workflows: Added results=[] and failed_count=0 Fixes #171
1 parent d7e6963 commit b5f0c5a

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

cortexapps_cli/commands/backup.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -472,6 +472,8 @@ def import_relationships_file(file_info):
472472
return ("entity-relationships", len(results) - failed_count, [(fp, et, em) for rt, fp, et, em in results if et])
473473

474474
def _import_catalog(ctx, directory):
475+
results = []
476+
failed_count = 0
475477
if os.path.isdir(directory):
476478
print("Processing: " + directory)
477479
files = [(filename, os.path.join(directory, filename))
@@ -507,6 +509,8 @@ def import_catalog_file(file_info):
507509
return ("catalog", len(results) - failed_count, [(fp, et, em) for fn, fp, et, em in results if et])
508510

509511
def _import_plugins(ctx, directory):
512+
results = []
513+
failed_count = 0
510514
if os.path.isdir(directory):
511515
print("Processing: " + directory)
512516
files = [(filename, os.path.join(directory, filename))
@@ -543,6 +547,8 @@ def import_plugin_file(file_info):
543547
return ("plugins", len(results) - failed_count, [(fp, et, em) for fn, fp, et, em in results if et])
544548

545549
def _import_scorecards(ctx, directory):
550+
results = []
551+
failed_count = 0
546552
if os.path.isdir(directory):
547553
print("Processing: " + directory)
548554
files = [(filename, os.path.join(directory, filename))
@@ -579,6 +585,8 @@ def import_scorecard_file(file_info):
579585
return ("scorecards", len(results) - failed_count, [(fp, et, em) for fn, fp, et, em in results if et])
580586

581587
def _import_workflows(ctx, directory):
588+
results = []
589+
failed_count = 0
582590
if os.path.isdir(directory):
583591
print("Processing: " + directory)
584592
files = [(filename, os.path.join(directory, filename))

0 commit comments

Comments
 (0)