tests: update tests and fix bugs

Author: mrholek

js/src/autocomplete.js

@@ -201,7 +201,7 @@ class Autocomplete extends BaseComponent {
 
     EventHandler.trigger(this._element, EVENT_SHOW)
     this._element.classList.add(CLASS_NAME_SHOW)
-    this._inputElement.setAttribute('aria-expanded', true)
+    this._inputElement.setAttribute('aria-expanded', 'true')
 
     if (this._config.container) {
       this._menu.style.minWidth = `${this._element.offsetWidth}px`

js/tests/unit/autocomplete.spec.js

@@ -105,8 +105,8 @@ describe('Autocomplete', () => {
       const autocompleteEl = fixtureEl.querySelector('.autocomplete')
       const autocomplete = new Autocomplete(autocompleteEl, { cleaner: true, options: [] })
 
-      expect(autocomplete._selectionCleanerElement).toBeTruthy()
-      expect(autocomplete._selectionCleanerElement.classList.contains('autocomplete-cleaner')).toBe(true)
+      expect(autocomplete._cleanerElement).toBeTruthy()
+      expect(autocomplete._cleanerElement.classList.contains('autocomplete-cleaner')).toBe(true)
     })
 
     it('should create autocomplete with indicator button when indicator option is true', () => {
@@ -173,7 +173,7 @@ describe('Autocomplete', () => {
         autocompleteEl.addEventListener('shown.coreui.autocomplete', () => {
           expect(autocomplete._isShown()).toBe(true)
           expect(autocompleteEl.classList.contains('show')).toBe(true)
-          expect(autocompleteEl.getAttribute('aria-expanded')).toBe('true')
+          expect(autocomplete._inputElement.getAttribute('aria-expanded')).toBe('true')
           resolve()
         })
 
@@ -252,7 +252,7 @@ describe('Autocomplete', () => {
         autocompleteEl.addEventListener('hidden.coreui.autocomplete', () => {
           expect(autocomplete._isShown()).toBe(false)
           expect(autocompleteEl.classList.contains('show')).toBe(false)
-          expect(autocompleteEl.getAttribute('aria-expanded')).toBe('false')
+          expect(autocomplete._inputElement.getAttribute('aria-expanded')).toBe('false')
           resolve()
         })
 
@@ -776,7 +776,7 @@ describe('Autocomplete', () => {
       autocomplete._inputElement.value = 'test'
       autocomplete._selected.push({ label: 'Option 1', value: '1' })
 
-      autocomplete._selectionCleanerElement.click()
+      autocomplete._cleanerElement.click()
 
       expect(autocomplete._inputElement.value).toBe('')
       expect(autocomplete._selected).toEqual([])
@@ -791,9 +791,9 @@ describe('Autocomplete', () => {
       })
 
       autocomplete._selected.push({ label: 'Option 1', value: '1' })
-      autocomplete._updateSelectionCleaner()
+      autocomplete._updateCleaner()
 
-      expect(autocomplete._selectionCleanerElement.style.display).not.toBe('none')
+      expect(autocomplete._cleanerElement.style.display).not.toBe('none')
     })
 
     it('should hide cleaner button when there are no selections', () => {
@@ -805,9 +805,9 @@ describe('Autocomplete', () => {
       })
 
       autocomplete._selected = []
-      autocomplete._updateSelectionCleaner()
+      autocomplete._updateCleaner()
 
-      expect(autocomplete._selectionCleanerElement.style.display).toBe('none')
+      expect(autocomplete._cleanerElement.style.display).toBe('none')
     })
   })
 

js/tests/unit/util/calendar.spec.js

@@ -7,11 +7,11 @@ import {
   getCalendarDate,
   getDateBySelectionType,
   getFirstAvailableDateInRange,
+  getISOWeekNumberAndYear,
   getMonthsNames,
   getSelectableDates,
   getYears,
   getMonthDetails,
-  getWeekNumber,
   isDateDisabled,
   isDateInRange,
   isDateSelected,
@@ -266,21 +266,21 @@ describe('Calendar Utilities', () => {
     })
   })
 
-  describe('getWeekNumber', () => {
+  describe('getISOWeekNumberAndYear', () => {
     it('should return correct ISO week number', () => {
       // 2023-01-01 is a Sunday => last week of 2022 in ISO
       const date = new Date(2023, 0, 1)
-      const weekNum = getWeekNumber(date)
+      const week = getISOWeekNumberAndYear(date)
       // The ISO week for Sunday 2023-01-01 is typically 52 or 52/53 from the previous year
       // We'll just ensure it's not 1
-      expect(weekNum).not.toBe(1)
+      expect(week.weekNumber).not.toBe(1)
     })
 
     it('should properly handle mid-year dates', () => {
       // Monday 2023-06-05 => ISO week 23
       const date = new Date(2023, 5, 5)
-      const weekNum = getWeekNumber(date)
-      expect(weekNum).toBe(23)
+      const week = getISOWeekNumberAndYear(date)
+      expect(week.weekNumber).toBe(23)
     })
   })