fix(sidebar-toggler): rtl position issue

xidedix · xidedix · commit 59062e2adf37 · 2018-09-27T16:46:11.000+02:00
diff --git a/scss/_layout.scss b/scss/_layout.scss
@@ -53,6 +53,7 @@ html:not([dir="rtl"]) {
     margin-left: - $sidebar-width;
   }
   .aside-menu {
+    right: 0;
     margin-right: - $aside-menu-width;
   }
 }
@@ -61,6 +62,7 @@ html[dir="rtl"] {
     margin-right: - $sidebar-width;
   }
   .aside-menu {
+    left: 0;
     margin-left: - $aside-menu-width;
   }
 }
@@ -471,7 +473,6 @@ html[dir="rtl"] {
 
   .aside-menu {
     position: fixed;
-    right: 0;
     height: 100%;
   }
 }
diff --git a/scss/_sidebar.scss b/scss/_sidebar.scss
@@ -342,7 +342,7 @@
         display: none;
       }
 
-      // Temporary fix for thsi issue: https://github.com/coreui/coreui-free-bootstrap-admin-template/issues/404
+      // Temporary fix for this issue: https://github.com/coreui/coreui-free-bootstrap-admin-template/issues/404
       // ToDo: find better solution
       .sidebar-minimizer {
         position: fixed;
@@ -490,4 +490,10 @@
       }
     }
   }
+
+  // Temp fix for rtl sidebar-toggler
+  // ToDo: find better solution
+  .sidebar-toggler {
+    margin-right: 0 !important;
+  }
 }

Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,7 @@ html:not([dir="rtl"]) {`
`53`	`53`	`margin-left: - $sidebar-width;`
`54`	`54`	`}`
`55`	`55`	`.aside-menu {`
	`56`	`+ right: 0;`
`56`	`57`	`margin-right: - $aside-menu-width;`
`57`	`58`	`}`
`58`	`59`	`}`
`@@ -61,6 +62,7 @@ html[dir="rtl"] {`
`61`	`62`	`margin-right: - $sidebar-width;`
`62`	`63`	`}`
`63`	`64`	`.aside-menu {`
	`65`	`+ left: 0;`
`64`	`66`	`margin-left: - $aside-menu-width;`
`65`	`67`	`}`
`66`	`68`	`}`
`@@ -471,7 +473,6 @@ html[dir="rtl"] {`
`471`	`473`
`472`	`474`	`.aside-menu {`
`473`	`475`	`position: fixed;`
`474`		`- right: 0;`
`475`	`476`	`height: 100%;`
`476`	`477`	`}`
`477`	`478`	`}`
Original file line number	Diff line number	Diff line change
`@@ -342,7 +342,7 @@`
`342`	`342`	`display: none;`
`343`	`343`	`}`
`344`	`344`
`345`		`- // Temporary fix for thsi issue: https://github.com/coreui/coreui-free-bootstrap-admin-template/issues/404`
	`345`	`+ // Temporary fix for this issue: https://github.com/coreui/coreui-free-bootstrap-admin-template/issues/404`
`346`	`346`	`// ToDo: find better solution`
`347`	`347`	`.sidebar-minimizer {`
`348`	`348`	`position: fixed;`
`@@ -490,4 +490,10 @@`
`490`	`490`	`}`
`491`	`491`	`}`
`492`	`492`	`}`
	`493`	`+`
	`494`	`+ // Temp fix for rtl sidebar-toggler`
	`495`	`+ // ToDo: find better solution`
	`496`	`+ .sidebar-toggler {`
	`497`	`+ margin-right: 0 !important;`
	`498`	`+ }`
`493`	`499`	`}`