Commit 3944c8c
committed
fix(security): never expose credentials via the request observer or test report
Security review findings on the reporting feature, all addressed:
- AuthInterceptor: the RequestObserver now receives a defensive request copy
with authtoken/authorization/access_token headers masked - the production
seam can no longer hand out credentials even if abused
- TestReporter: request cURL bodies and response bodies are passed through
redactSecrets() before entering the report - passwords, session authtokens,
management/delivery token values (cs*), OAuth and TOTP secrets are replaced
with ***REDACTED***. The report ships as a CI artifact, so no live secret
may survive into it (previously the login cURL contained the account
password and token-creation responses contained live token values)
Verified: suite 252/0 failures; regenerated report scan shows zero authtoken
values, zero cs* tokens, zero password strings (23 redaction markers). The
one session token exposed in a local report was invalidated via logout.1 parent ae6a735 commit 3944c8c
2 files changed
Lines changed: 40 additions & 2 deletions
File tree
- src
- main/java/com/contentstack/cms/core
- test/java/com/contentstack/cms
Lines changed: 17 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
106 | | - | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
107 | 110 | | |
108 | 111 | | |
109 | 112 | | |
110 | 113 | | |
111 | 114 | | |
112 | 115 | | |
113 | 116 | | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
114 | 130 | | |
115 | 131 | | |
116 | 132 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
| 110 | + | |
110 | 111 | | |
111 | 112 | | |
112 | 113 | | |
| |||
132 | 133 | | |
133 | 134 | | |
134 | 135 | | |
135 | | - | |
| 136 | + | |
136 | 137 | | |
137 | 138 | | |
138 | 139 | | |
| |||
142 | 143 | | |
143 | 144 | | |
144 | 145 | | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
145 | 167 | | |
146 | 168 | | |
147 | 169 | | |
| |||
0 commit comments