Skip to content

Commit 6ce10b7

Browse files
authored
Merge pull request #121 from contentstack/fix/snyk
fix: suppress false-positive Snyk hardcoded-password finding
2 parents 0a84b92 + e9d01e9 commit 6ce10b7

2 files changed

Lines changed: 35 additions & 6 deletions

File tree

.github/workflows/sca-scan.yml

Lines changed: 34 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,40 @@ jobs:
1010
pull-requests: write
1111
steps:
1212
- uses: actions/checkout@master
13-
- name: Run Snyk to check for vulnerabilities
14-
uses: snyk/actions/gradle@master
13+
14+
- name: Set up JDK 17
15+
uses: actions/setup-java@v4
16+
with:
17+
distribution: 'temurin'
18+
java-version: '17'
19+
cache: 'gradle'
20+
21+
- name: Set up Android SDK
22+
uses: android-actions/setup-android@v3
23+
with:
24+
packages: 'tools platform-tools platforms;android-34 build-tools;34.0.0'
25+
26+
- name: Setup local.properties
27+
run: |
28+
cat << EOF >> local.properties
29+
sdk.dir=$ANDROID_HOME
30+
host="${{ secrets.HOST }}"
31+
APIKey="${{ secrets.API_KEY }}"
32+
deliveryToken="${{ secrets.DELIVERY_TOKEN }}"
33+
environment="${{ secrets.ENVIRONMENT }}"
34+
contentType="${{ secrets.CONTENT_TYPE }}"
35+
assetUid="${{ secrets.ASSET_UID }}"
36+
EOF
37+
38+
- name: Set up Snyk
39+
uses: snyk/actions/setup@master
40+
with:
41+
snyk-version: latest
42+
43+
- name: Run Snyk
1544
env:
1645
SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }}
17-
with:
18-
args: --fail-on=all --all-sub-projects
19-
json: true
46+
run: snyk test --fail-on=all --all-sub-projects --json > snyk.json
2047
continue-on-error: true
21-
- uses: contentstack/sca-policy@main
48+
49+
- uses: contentstack/sca-policy@main

contentstack/src/test/java/com/contentstack/sdk/TestError.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -283,6 +283,7 @@ public void testNetworkErrorScenario() {
283283
public void testValidationErrorScenario() {
284284
HashMap<String, Object> validationErrors = new HashMap<>();
285285
validationErrors.put("email", "Invalid email format");
286+
// deepcode ignore HardcodedPassword: test fixture value, not a real secret
286287
validationErrors.put("password", "Password too short");
287288

288289
error.setErrorMessage("Validation failed");

0 commit comments

Comments
 (0)