Stricter typings on managers

Author: masked-rpgmaker

lib/external/effekseer.d.ts

@@ -1,38 +1,38 @@
 declare namespace effekseer {
 
     /**
-    * Initialize Effekseer.js.
-    * This function must be called at first if use WebAssembly
-    * @param {string} path A file of webassembply
-    * @param {function=} onload A function that is called at loading complete
-    * @param {function=} onerror A function that is called at loading error.
-    */
+     * Initialize Effekseer.js.
+     * This function must be called at first if use WebAssembly
+     * @param {string} path A file of webassembply
+     * @param {function=} onload A function that is called at loading complete
+     * @param {function=} onerror A function that is called at loading error.
+     */
     export function initRuntime(path, onload, onerror);
 
     /**
-    * Create a context to render in multiple scenes
-    * @returns {EffekseerContext} context
-    */
+     * Create a context to render in multiple scenes
+     * @returns {EffekseerContext} context
+     */
     export function createContext(): EffekseerContext;
 
     /**
-    * Release specified context. After that, don't touch a context
-    * @param {EffekseerContext} context context
-    */
+     * Release specified context. After that, don't touch a context
+     * @param {EffekseerContext} context context
+     */
     export function releaseContext(context: EffekseerContext);
 
     /**
-         * Initialize graphics system.
-         * @param {WebGLRenderingContext} webglContext WebGL Context
-         * @param {object} settings Some settings with Effekseer initialization
-         */
-    export function init(webglContext, settings?: object);
+     * Initialize graphics system.
+     * @param {WebGLRenderingContext} webglContext WebGL Context
+     * @param {object} settings Some settings with Effekseer initialization
+     */
+    export function init(webglContext, settings ?: Record<string, unknown>);
 
     /**
      * Advance frames.
      * @param {number=} deltaFrames number of advance frames
      */
-    export function update(deltaFrames?: number);
+    export function update(deltaFrames ? : number);
 
     /**
      * Main rendering.
@@ -109,12 +109,12 @@ declare namespace effekseer {
      * @param {function=} onerror A function that is called at loading error. First argument is a message. Second argument is an url.
      * @returns {EffekseerEffect} The effect data
      */
-    export function loadEffect(path: string, scale?: number, onload?, onerror?): EffekseerEffect;
+    export function loadEffect(path: string, scale ? : number, onload ? , onerror ? ): EffekseerEffect;
 
     /**
-    * Release the specified effect. Don't touch the instance of effect after released.
-    * @param {EffekseerEffect} effect The loaded effect
-    */
+     * Release the specified effect. Don't touch the instance of effect after released.
+     * @param {EffekseerEffect} effect The loaded effect
+     */
     export function releaseEffect(effect: EffekseerEffect);
 
     /**
@@ -139,23 +139,23 @@ declare namespace effekseer {
     export function setResourceLoader(loader);
 
     /**
-    * Get whether VAO is supported
-    */
+     * Get whether VAO is supported
+     */
     export function isVertexArrayObjectSupported();
 
     export class EffekseerContext {
         /**
-             * Initialize graphics system.
-             * @param {WebGLRenderingContext} webglContext WebGL Context
-             * @param {object} settings Some settings with Effekseer initialization
-             */
-        init(webglContext, settings?: object);
+         * Initialize graphics system.
+         * @param {WebGLRenderingContext} webglContext WebGL Context
+         * @param {Record<string, unknown>} settings Some settings with Effekseer initialization
+         */
+        init(webglContext: WebGLRenderingContextBase, settings?: Record<string, unknown>): void;
 
         /**
          * Advance frames.
          * @param {number=} deltaFrames number of advance frames
          */
-        update(deltaFrames?: number);
+        update(deltaFrames?: number): void;
 
         /**
          * Main rendering.
@@ -233,12 +233,12 @@ declare namespace effekseer {
          * @param {function=} redirect A function to redirect a path. First argument is an url and return redirected url.
          * @returns {EffekseerEffect} The effect data
          */
-        loadEffect(path: string, scale?: number, onload?, onerror?, redirect?): EffekseerEffect;
+        loadEffect(path: string, scale ? : number, onload ? , onerror ? , redirect ? ): EffekseerEffect;
 
         /**
-        * Release the specified effect. Don't touch the instance of effect after released.
-        * @param {EffekseerEffect} effect The loaded effect
-        */
+         * Release the specified effect. Don't touch the instance of effect after released.
+         * @param {EffekseerEffect} effect The loaded effect
+         */
         releaseEffect(effect: EffekseerEffect);
 
         /**
@@ -263,8 +263,8 @@ declare namespace effekseer {
         setResourceLoader(loader);
 
         /**
-        * Get whether VAO is supported
-        */
+         * Get whether VAO is supported
+         */
         isVertexArrayObjectSupported();
 
         /**
@@ -280,7 +280,7 @@ declare namespace effekseer {
          * get paths to color images
          * @returns {Array<string>} paths to color images
          */
-        getColorImagePaths(): Array<string>;
+        getColorImagePaths(): Array < string > ;
     }
 
     export class EffekseerHandle {
@@ -343,7 +343,7 @@ declare namespace effekseer {
          * @param {number} index slot index
          * @returns {number} value
          */
-        getDynamicInput(index) : number;
+        getDynamicInput(index): number;
 
         /**
          * specfiy a dynamic parameter, which changes effect parameters dynamically while playing
@@ -375,4 +375,4 @@ declare namespace effekseer {
 
 declare module "effekseer" {
     export = effekseer;
-}
+}

lib/rpg_manager/AudioManager.d.ts

@@ -1,6 +1,5 @@
 import { WebAudio } from "../rpg_core/WebAudio";
 
-
 declare interface CurrentAudio {
     name: string;
     volume: number;
@@ -10,7 +9,6 @@ declare interface CurrentAudio {
 }
 
 declare class AudioManager {
-
     private static _bgmVolume: number;
     private static _bgsVolume: number;
     private static _meVolume: number;
@@ -26,16 +24,16 @@ declare class AudioManager {
     private static _path: string;
 
     public static get bgmVolume(): number;
-    public static set bgmVolume(value: number): number;
+    public static set bgmVolume(value: number);
 
     public static get bgsVolume(): number;
-    public static set bgsVolume(value: number): number;
+    public static set bgsVolume(value: number);
 
     public static get meVolume(): number;
-    public static set meVolume(value: number): number;
+    public static set meVolume(value: number);
 
     public static get seVolume(): number;
-    public static set seVolume(value: number): number;
+    public static set seVolume(value: number);
 
     public static playBgm(bgm: CurrentAudio, pos: number): void;
     public static replayBgm(bgm: CurrentAudio): void;

lib/rpg_manager/BattleManager.d.ts

@@ -20,9 +20,9 @@ declare class BattleManager {
     private static _targets: unknown[];
     private static _logWindow: unknown;
     private static _spriteset;
-    private static _escapeRatio = 0;
-    private static _escaped = false;
-    private static _rewards = {};
-    private static _tpbNeedsPartyCommand = true;
+    private static _escapeRatio: number;
+    private static _escaped: boolean;
+    private static _rewards: Record<string, unknown>;
+    private static _tpbNeedsPartyCommand: boolean;
 
 }

lib/rpg_manager/ColorManager.d.ts

@@ -26,7 +26,7 @@ declare class ColorManager {
     public static tpGaugeColor2(): string;
     public static tpCostColor(): string;
     public static pendingColor(): string;
-    public static hpColor(actor: any): string; // TODO : make sure it's an edited as an actor.
+    public static hpColor(actor: Game_Actor): string;
     public static mpColor(): string;
     public static tpColor(): string;
     public static paramchangeTextColor(change: number): string;

lib/rpg_manager/ConfigManager.d.ts

@@ -17,20 +17,23 @@ declare class ConfigManager {
     private static _isLoaded: boolean;
 
     private static _bgmVolume: number;
-    private static bgsVolume: number;
-    private static meVolume: number;
-    private static seVolume: number;
+    private static _bgsVolume: number;
+    private static _meVolume: number;
+    private static _seVolume: number;
 
     constructor();
 
     public static get bgmVolume(): number;
-    public static set bgmVolume(value: number): number;
+    public static set bgmVolume(value: number);
+
     public static get bgsVolume(): number;
-    public static set bgsVolume(value: number): number;
+    public static set bgsVolume(value: number);
+
     public static get meVolume(): number;
-    public static set meVolume(value: number): number;
+    public static set meVolume(value: number);
+    
     public static get seVolume(): number;
-    public static set seVolume(value: number): number;
+    public static set seVolume(value: number);
 
     public static load(): void;
     public static save(): void;