Error catch better ci

Author: mcbarton

.github/workflows/main.yml

@@ -357,28 +357,33 @@ jobs:
           sleep 10
           echo "Running xeus-cpp in Jupter Lite in Chrome"
           python -u scripts/automated-notebook-run-script.py --driver chrome --notebook ${{ matrix.notebook }} --kernel ${{ matrix.kernel }}
-          echo "Diff Notebooks Chrome"
-          nbdiff notebooks/${{ matrix.notebook }} $HOME/Downloads/${{ matrix.notebook }} --ignore-id --ignore-metadata
-          export CHROME_TESTS_RETURN_VALUE=$?
+          nbdiff notebooks/${{ matrix.notebook }} $HOME/Downloads/${{ matrix.notebook }} --ignore-id --ignore-metadata >> chrome_diff.txt
+          export CHROME_TESTS_RETURN_VALUE=$( [ -s chrome_diff.txt ] && echo 1 || echo 0 )
           echo "Running xeus-cpp in Jupter Lite in Firefox"
           python -u scripts/automated-notebook-run-script.py --driver firefox --notebook ${{ matrix.notebook }} --kernel ${{ matrix.kernel }}
-          echo "Diff Notebooks Firefox"
-          nbdiff notebooks/${{ matrix.notebook }} $HOME/Downloads/${{ matrix.notebook }} --ignore-id --ignore-metadata
-          export FIREFOX_TESTS_RETURN_VALUE=$?
+          nbdiff notebooks/${{ matrix.notebook }} $HOME/Downloads/${{ matrix.notebook }} --ignore-id --ignore-metadata >> firefox_diff.txt
+          export FIREFOX_TESTS_RETURN_VALUE=$( [ -s firefox_diff.txt ] && echo 1 || echo 0 )
           rm $HOME/Downloads/${{ matrix.notebook }}      
           export SAFARI_TESTS_RETURN_VALUE=0
+	  touch safari_diff.txt
           if [[ "${{ matrix.os }}" == "macos"* ]]; then
             python -m pip install PyAutoGUI
             python scripts/enable-downloads-safari-github-ci.py
             python -u scripts/automated-notebook-run-script.py --driver safari --notebook ${{ matrix.notebook }} --kernel ${{ matrix.kernel }}
             echo "Running xeus-cpp in Jupter Lite in  Safari"
-            echo "Diff Notebooks Safari"
-            nbdiff notebooks/${{ matrix.notebook }} $HOME/Downloads/${{ matrix.notebook }} --ignore-id --ignore-metadata
-            export SAFARI_TESTS_RETURN_VALUE=$?
+            nbdiff notebooks/${{ matrix.notebook }} $HOME/Downloads/${{ matrix.notebook }} --ignore-id --ignore-metadata >> safari_diff.txt
+            export SAFARI_TESTS_RETURN_VALUE=$( [ -s safari_diff.txt ] && echo 1 || echo 0 )
             rm $HOME/Downloads/${{ matrix.notebook }}
           fi
           if [[ $SAFARI_TESTS_RETURN_VALUE -ne 0 || $FIREFOX_TESTS_RETURN_VALUE -ne 0 || $CHROME_TESTS_RETURN_VALUE -ne 0 ]]; then
-            echo "Diff for Safari, Chrome or Firefox returned non zero value (could be more than one)"
+            if [[ "${{ matrix.os }}" == "macos"* ]]; then
+               echo "Diff Safari (blank means no diff)"
+               cat safari_diff.txt
+            fi
+            echo "Diff Firefox (blank means no diff)"
+            cat firefox_diff.txt
+            echo "Diff Chrome (blank means no diff)"
+	    cat chrome_diff.txt
             exit 1
           fi
         timeout-minutes: 15