environment tests, improve thread safety

Author: mr-c

tests/test_environment.py

@@ -188,18 +188,21 @@ def BIND(v: str, env: Env) -> bool:
 
 # CRT = container runtime
 CRT_PARAMS = pytest.mark.parametrize(
-    "crt_params",
+    "crt_params_",
     [
-        NoContainer(),
-        pytest.param(Docker(), marks=needs_docker),
-        pytest.param(Singularity(), marks=needs_singularity),
+        NoContainer,
+        pytest.param(Docker, marks=needs_docker),
+        pytest.param(Singularity, marks=needs_singularity),
     ],
 )
 
 
 @CRT_PARAMS
-def test_basic(crt_params: CheckHolder, tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> None:
+def test_basic(
+    crt_params_: type[CheckHolder], tmp_path: Path, monkeypatch: pytest.MonkeyPatch
+) -> None:
     """Test that basic env vars (only) show up."""
+    crt_params = crt_params_()
     tmp_prefix = str(tmp_path / "canary")
     extra_env = {
         "USEDVAR": "VARVAL",
@@ -219,9 +222,10 @@ def test_basic(crt_params: CheckHolder, tmp_path: Path, monkeypatch: pytest.Monk
 
 @CRT_PARAMS
 def test_preserve_single(
-    crt_params: CheckHolder, tmp_path: Path, monkeypatch: pytest.MonkeyPatch
+    crt_params_: type[CheckHolder], tmp_path: Path, monkeypatch: pytest.MonkeyPatch
 ) -> None:
     """Test that preserving a single env var works."""
+    crt_params = crt_params_()
     tmp_prefix = str(tmp_path / "canary")
     extra_env = {
         "USEDVAR": "VARVAL",
@@ -245,12 +249,13 @@ def test_preserve_single(
 
 @CRT_PARAMS
 def test_preserve_single_missing(
-    crt_params: CheckHolder,
+    crt_params_: type[CheckHolder],
     tmp_path: Path,
     monkeypatch: pytest.MonkeyPatch,
     caplog: pytest.LogCaptureFixture,
 ) -> None:
     """Test that attempting to preserve an unset env var produces a warning."""
+    crt_params = crt_params_()
     tmp_prefix = str(tmp_path / "canary")
     args = crt_params.flags + [
         f"--tmpdir-prefix={tmp_prefix}",
@@ -272,9 +277,10 @@ def test_preserve_single_missing(
 
 @CRT_PARAMS
 def test_preserve_all(
-    crt_params: CheckHolder, tmp_path: Path, monkeypatch: pytest.MonkeyPatch
+    crt_params_: type[CheckHolder], tmp_path: Path, monkeypatch: pytest.MonkeyPatch
 ) -> None:
     """Test that preserving all works."""
+    crt_params = crt_params_()
     tmp_prefix = str(tmp_path / "canary")
     extra_env = {
         "USEDVAR": "VARVAL",