fix(bump): remove NotAllowed related to --get-next option, and other related refactoring
#1644
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
dry_run = Truewhile we already haveget_next = True. The latter condition raises aGetNextExit()exception in the original code, so no effect if we setdry_runtoTrue. Moreover, the original code isself.dry_run = Truewhich is ineffective since we never use the member variable.get_nexttonext_version_to_stdout. The variable nameget_nextis very unclear and hard to guess what it will do. I think we can consider renaming the option in the next major release.--get-nextwhen changelog is enabled #1640) ReplaceNotAllowedrelated to--get-nextoption with warnings.GetNextExitexception because we already haveDryRunExit.--get-nextis just--dry-runbut doing less things IMO.