-
-
Notifications
You must be signed in to change notification settings - Fork 301
test(utils): do not create file for simplicity #1621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(utils): do not create file for simplicity #1621
Conversation
…of potential type error
…hook question, simplify logic, remove unreachable code path
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v4-10-1 #1621 +/- ##
==========================================
Coverage ? 98.32%
==========================================
Files ? 58
Lines ? 2684
Branches ? 0
==========================================
Hits ? 2639
Misses ? 45
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I'm not sure I understand the benefit we gain from this. Could you please share more insights? Thanks! |
|
probably no. I remember I was thinking not creating file makes the tests faster. |
No description provided.