[ISSUE#51]: writing tests

Signed-off-by: ashish <ashishpatel0720@gmail.com>

Author: pateash

src/commands/avro.ts

@@ -8,7 +8,13 @@ import Utilities from '../utilities/utilities'
 
 export default class Avro extends Command {
   static description = 'Avro Utility command'
-  static SupportedCommands = ['get_schema', 'to_json', 'to_avro']
+
+  static GET_SCHEMA = 'get_schema'
+  static TO_JSON = 'to_json'
+  static TO_AVRO = 'to_avro'
+
+  // do not change order otherwise we need to change order in getCommand() also
+  static SupportedCommands = [Avro.GET_SCHEMA, Avro.TO_JSON, Avro.TO_AVRO]
   static flags = {
     help: flags.help({char: 'h'}),
     file: flags.string({char: 'f' , description: 'input file path'}),
@@ -30,16 +36,22 @@ export default class Avro extends Command {
 
   // to check required parameters passed or not
   private checkParameters(flags: any, args: any) {
-    if (flags.file === undefined || flags.file === '')
+    if (!flags.file)
       Logger.error(this, 'Input file is not provided')
-    if (flags.output === undefined || args.output === '')
-      Logger.error(this, 'Output file is not provided')
-    if (args.command === undefined || args.command === '')
+    if (!args.command)
       Logger.error(this, 'Command is empty or not provided, supported:' + Avro.SupportedCommands)
+
+    // if exists then make it upperCase
+    args.command = args.command.toLowerCase()
+
+    // output is not mendatory for 'get_schema' command
+    if (args.command !== Avro.GET_SCHEMA && !flags.output)
+      Logger.error(this, 'Output file is not provided')
+
   }
 
   private executeCommand(flags: any, args: any) {
-    switch (args.command.toLowerCase()) {
+    switch (args.command) {
     case Avro.SupportedCommands[0]:
       return this.getSchema(flags, args)
     case Avro.SupportedCommands[1]:

test/commands/avro.test.ts

@@ -5,7 +5,7 @@ import {expect, test} from '@oclif/test'
 describe('avro', () => {
   //todo if file is invalid
   test
-    .timeout(10000) // added timeout to remove timeout problem
+    .timeout(10000) // added timeout to resolve timeout problem
     .stdout()
     .command(['avro'])
     .exit(0)
@@ -14,21 +14,21 @@ describe('avro', () => {
     })
   test
     .stdout()
-    .command(['avro', '-f' ,'test/resources/avro/person.avro'])
+    .command(['avro', '-f', 'test/resources/avro/person.avro', 'to_avro'])
     .exit(0)
-    .it('if output is not passed', ctx => {
+    .it('if output file is not passed when mendatory', ctx => {
       expect(ctx.stdout).to.contain('Output file is not provided')
     })
   test
     .stdout()
-    .command(['avro', '-f' ,'test/resources/avro/person.avro', '-o', 'output_file.example'])
+    .command(['avro', '-f', 'test/resources/avro/person.avro', '-o', 'output_file.example'])
     .exit(0)
     .it('if command not passed', ctx => {
       expect(ctx.stdout).to.contain('Command is empty or not provided')
     })
   test
     .stdout()
-    .command(['avro', '-f' ,'test/resources/avro/person.avro', '-o', 'output_file.example', 'unsupported_command'])
+    .command(['avro', '-f', 'test/resources/avro/person.avro', '-o', 'output_file.example', 'unsupported_command'])
     .exit(0)
     .it('if command is invalid', ctx => {
       expect(ctx.stdout).to.contain('Unsupported Command')
@@ -45,7 +45,7 @@ describe('avro', () => {
 
   test
     .stdout()
-    .command(['avro', '-f' ,'test/resources/avro/person.avro', '-o', 'output_file.example', 'to_avro'])
+    .command(['avro', '-f', 'test/resources/avro/person.avro', '-o', 'output_file.example', 'to_avro'])
     .exit(0)
     .it('if schema file path is not passed for to_avro', ctx => {
       expect(ctx.stdout).to.contain('Schema file is not provided')
@@ -55,4 +55,13 @@ describe('avro', () => {
   // 1 - get schema
   // 2 - to json
   // 3 - to avro
+
+  test
+    .stdout()
+    .command(['avro', '-f', 'test/resources/avro/person.avro', 'get_schema'])
+    .it('if get_schema outputs to console', ctx => {
+      expect(ctx.stdout).to.contain('success')
+    })
+
+
 })

test/commands/hash.test.ts

@@ -2,6 +2,7 @@ import {expect, test} from '@oclif/test'
 
 describe('hash', () => {
   test
+    .timeout(10000) // added timeout to resolve timeout problem
     .stdout()
     .command(['hash', 'ashish'])
     .it("Check default type -> cdt hash 'ashish'", ctx => {