Commit 0caaa5a
authored
Drop custom separator in favor of default colon (
* Drop custom separator in favor of default colon (`:`)
Dot is unreserved character, however the representation in browsers (`%2E` or `.`), mail clients and even SMTP-servers is not unified and can lead to different issues:
- https://wordtothewise.com/2018/11/why-do-my-urls-have-two-dots/
- https://bugs.python.org/issue43922
Also, Django is using dot for some funky JSON compression in `django.core.signing`:
https://github.com/django/django/blob/4f8c7fd9d91b35e2c2922de4bb50c8c8066cbbc6/django/core/signing.py#L29-L30
So, in this PR I am suggesting to drop custom separator and switch to the default colon (`:`).
It is also not reserved of anything in domain path, but only in host and scheme parts.
- https://www.rfc-editor.org/rfc/rfc3986#section-3.3
- https://security.stackexchange.com/questions/159099/colons-in-urls-safe
* Change token
* Pin psycopg2-binary<2.9 in CI
Django versions <3 have no compatibility with psycopg-binary>=2.9.
django/django#14530
I'd be up for dropping Django 2.2 completely, as it is now only receiving security support, but we also can wait until April and simply pin psycopg-binary in CI until then (as I would not expect anything breaking because of that).
* Fix token for Django 2.2:) (#28)1 parent 563e4e3 commit 0caaa5a
3 files changed
+3
-6
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
127 | 127 | | |
128 | 128 | | |
129 | 129 | | |
130 | | - | |
| 130 | + | |
131 | 131 | | |
132 | 132 | | |
133 | 133 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | 28 | | |
32 | 29 | | |
33 | 30 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
42 | | - | |
| 41 | + | |
| 42 | + | |
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| |||
0 commit comments