Skip to content

Commit 17c80ae

Browse files
author
Zaydek Michels-Gualtieri
committed
Added a case to support emojis
1 parent cfab65c commit 17c80ae

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

src/Editor/Elements/Elements.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,7 @@ export const AnyListItem = ({ id, syntax, ordered, children }) => (
159159

160160
// TODO: Add markdown to CSS to prevent useless rerenders
161161
export const TodoItem = React.memo(({ id, syntax, checked, children, dispatch }) => {
162-
// const [, { checkTodo }] = useEditorState()
163162
const ref = React.useRef()
164-
165163
return (
166164
<li id={id} className="relative my-1" data-codex-checked={checked}>
167165
<Markdown className="hidden" syntax={syntax}>
@@ -187,7 +185,7 @@ export const TodoItem = React.memo(({ id, syntax, checked, children, dispatch })
187185
checked={checked}
188186
onChange={() => {
189187
ref.current.focus()
190-
dispatch(id)
188+
dispatch.checkTodo(id)
191189
}}
192190
/>
193191
</div>

src/Editor/useEditor.js

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -362,26 +362,28 @@ const methods = state => ({
362362
console.log("parseElements", Date.now() - t)
363363

364364
if (renderOpts.rerenderIfNeeded) {
365-
366-
let mustRerender = true
365+
let rerenderNeeded = true
367366

368367
let id = ""
369368
const selection = document.getSelection()
370369
if (selection.rangeCount) {
371370
const range = selection.getRangeAt(0)
372-
mustRerender = (
371+
rerenderNeeded = (
373372
(range.startContainer.nodeType === Node.TEXT_NODE && range.startOffset <= 1) ||
374-
ascendToElement(range.startContainer).getAttribute("data-codex-markdown")
373+
// TODO: Add data-codex-rerender?
374+
ascendToElement(range.startContainer).getAttribute("data-codex-markdown") ||
375+
ascendToElement(range.startContainer).getAttribute("aria-label")
375376
)
376377
const root = ascendToElement(range.startContainer).closest("[data-codex-editor] > *")
377378
id = root.id || root.querySelector("[id]").id
378379
}
379-
if (mustRerender) {
380+
381+
// if (rerenderNeeded) {
380382
const nextElement = nextElements.find(each => each.id === id)
381383
if (nextElement) {
382384
nextElement.reactKey = uuidv4().slice(0, 8)
383385
}
384-
}
386+
// }
385387

386388
// const elements = parseInlineElements(state.nodes[state.pos1.y].data)
387389
// console.log(elements)

src/EditorApp/EditorApp.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ const EditorApp = () => {
223223
{/* RHS */}
224224
<div className="flex-shrink-0 hidden lg:block w-16"></div>
225225
<div className="xl:flex-shrink-0 w-full max-w-3xl">
226-
<DocumentTitleAndEmoji title={(meta.title || "Untitled") + " (v0.6)"} emoji={meta.emoji}>
226+
<DocumentTitleAndEmoji title={(meta.title || "Untitled") + " (v0.7)"} emoji={meta.emoji}>
227227
<div className="relative">
228228

229229
{/* Placeholder */}

0 commit comments

Comments
 (0)