Fixed toaster notification close button bug

Author: Kyle Andrews

CHANGELOG.md

@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.2.1] - 2020-04-17
+
+### Fixed
+
+-   toaster notification close button bug
+
 ## [1.2.0] - 2020-04-04
 
 ### Added

package.json

@@ -1,6 +1,6 @@
 {
     "name": "@codewithkyle/notifyjs",
-    "version": "1.2.0",
+    "version": "1.2.1",
     "description": "A simple JavaScript library for creating and managing toaster & snackbar notifications",
     "main": "notify.js",
     "types": "notify.d.ts",

src/notification-manager.ts

@@ -145,7 +145,7 @@ export class NotificationManager {
                 for (let i = 0; i < this.toaster.length; i++) {
                     this.toaster[i].duration -= deltaTime;
                     if (this.toaster[i].duration <= 0) {
-                        this.removeToasterNotification(this.toaster[i], i);
+                        this.removeToasterNotification(i);
                     }
                 }
             }
@@ -335,14 +335,23 @@ export class NotificationManager {
 
     public snackbar = this.notify;
 
-    private removeToasterNotification(notification: ToasterNotification, id: number) {
-        notification.element.remove();
-        this.toaster.splice(id, 1);
+    private removeToasterNotification(index: number) {
+        this.toaster[index].element.remove();
+        this.toaster.splice(index, 1);
     }
     private handleToastClose: EventListener = (e: Event) => {
         const target = e.currentTarget as HTMLButtonElement;
-        const id = parseInt(target.parentElement.dataset.id);
-        this.removeToasterNotification(this.toaster[id], id);
+        const notificationId = target.parentElement.dataset.id;
+        let index = null;
+        for (let i = 0; i < this.toaster.length; i++) {
+            if (this.toaster[i].element.dataset.id === notificationId) {
+                index = i;
+                break;
+            }
+        }
+        if (index) {
+            this.removeToasterNotification(index);
+        }
     };
 
     private createToast(notification: ToasterNotification) {
@@ -387,7 +396,7 @@ export class NotificationManager {
         }
 
         const notificationEl = this.createToast(notification);
-        notificationEl.dataset.id = `${this.toaster.length}`;
+        notificationEl.dataset.id = `${performance.now()}`;
         notification.element = notificationEl;
 
         if (notification?.duration && !isNaN(notification.duration)) {