flake: TestOrganizationDelete/Yes

[flake-investigator]

CI Failure Information

CI Run Link: https://github.com/coder/coder/actions/runs/23844531559
Job: test-go-pg (ubuntu-latest) (job ID: 69508462441)
Commit: 7ddde0887bd9a662a1ba7b33988e551d2655b667 — "feat(site): force-enable kyleosophy on dev.coder.com (#23892)" by Cian Johnston

Failure Details

Test: cli.TestOrganizationDelete/Yes

Error Snippet:

organization_test.go:137:
    Error: Received unexpected error:
            running command "coder organizations delete": delete organization "my-org":
              github.com/coder/coder/v2/cli.(*RootCmd).deleteOrganization.func1
                /home/runner/work/coder/coder/cli/organizationdelete.go:51
              - execute request:
                github.com/coder/coder/v2/codersdk.(*Client).DeleteOrganization
                  /home/runner/work/coder/coder/codersdk/organizations.go:324
              - Delete "http://127.0.0.1:43015/api/v2/organizations/8158f2a6-90f9-413d-9139-883a3f37b667": net/http: HTTP/1.x transport connection broken: http: CloseIdleConnections called

Test Summary: DONE 19269 tests, 57 skipped, 2 failures in 291.725s

Root Cause Analysis

• No data race warnings detected
• No panic/OOM indicators detected
• Failure appears to be a flaky HTTP transport issue where the underlying transport gets CloseIdleConnections called while a request is in flight.
• codersdk.New uses &http.Client{} which inherits the global default transport. Other tests/cleanup paths call CloseIdleConnections on shared transports, which can break concurrent requests in parallel tests.

Assignment Analysis

• Failing test function: TestOrganizationDelete/Yes in cli/organization_test.go.
• git log --oneline --follow cli/organization_test.go (via GitHub commit history):
  • 683a7c0957 (Rowan Smith) — add organizations list command + tests
  • e3ce3c342a (Rowan Smith) — add organization delete command + tests
  • 7ea1a4c686 (Steven Masley) — earlier organization CLI changes
• Rowan Smith is the most recent substantive modifier, but their GitHub account is not assignable in coder/internal; assigning to @Emyrk as CLI org-context owner and prior modifier in this file.

Related Issues

• stop using the default, global HTTP client to avoid CloseIdleConnections flakes #1020 (shared HTTP transport CloseIdleConnections flakes)

Reproduction

go test ./cli -run TestOrganizationDelete/Yes -count=1