fix: Windows compatibility #540
Open
+1,186
−259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fix: improved windows compatibility 🤖 fix: publish Windows .exe in release workflow\n\n- Add Windows job to build and publish NSIS .exe\n- Install ImageMagick on Windows in setup-cmux action\n- Set Windows icon and artifactName in electron-builder config\n\n_Generated with _ fix: chalk tests improvements fix: codex review WIP 🤖 feat: add unified cross-platform path utilities for Windows compatibility - Created PlatformPaths utility class for OS-aware path operations - Added UI-specific path formatting utilities for renderer process - Updated all path handling to use centralized utilities - Refactored pathAbbreviation to support Windows paths (C:\U\j\D\project) - Updated components: ProjectSidebar, NewWorkspaceModal, SecretsModal - Updated config.ts to use PlatformPaths for project name extraction - Eliminated 6+ instances of duplicated path splitting logic - Added comprehensive test suite (33 tests, all passing) - Added src/utils/platform/ to ESLint main-process exclusions This change prepares cmux for Windows support by centralizing all path operations into platform-aware utilities, ensuring correct behavior on Windows, macOS, and Linux. WIP fix: path cleanup fix: fmt fix: tests & fmt fix: exclude heavy dirs from watch fix: ssh workdir fix: test WIP fix: fmt
ibetitsmike
force-pushed
the
mike/windows-build-fix
branch
from
e7425ed to
ef8286d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated with .
This PR improves Windows build compatibility:
If you want me to expand the description with specific diffs, say "elaborate".