Update: Improved code quality.

Author: chikondikamwendo

database/factories/TestModelFactory.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Codelabmw\InfiniteScroll\Database\Factories;
 
 use Codelabmw\Tests\Fixtures\TestModel;
@@ -8,7 +10,7 @@
 /**
  * @extends Factory<TestModel>
  */
-class TestModelFactory extends Factory
+final class TestModelFactory extends Factory
 {
     /**
      * The name of the factory's corresponding model.
@@ -24,4 +26,4 @@ public function definition(): array
     {
         return [];
     }
-}
+}

database/migrations/create_test_table.php

@@ -1,10 +1,12 @@
 <?php
 
+declare(strict_types=1);
+
 use Illuminate\Database\Migrations\Migration;
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
 
-return new class () extends Migration
+return new class() extends Migration
 {
     public function up(): void
     {
@@ -18,4 +20,4 @@ public function down(): void
     {
         Schema::dropIfExists('test_models');
     }
-};
+};

src/Enums/PaginationType.php

@@ -1,9 +1,11 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Codelabmw\InfiniteScroll\Enums;
 
 enum PaginationType: string
 {
     case CURSOR = 'cursor';
     case PAGED = 'paged';
-}
+}

src/Facades/InfiniteScroll.php

@@ -1,10 +1,15 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Codelabmw\InfiniteScroll\Facades;
 
 use Illuminate\Support\Facades\Facade;
 
-class InfiniteScroll extends Facade
+/**
+ * @codeCoverageIgnore
+ */
+final class InfiniteScroll extends Facade
 {
     /**
      * Get the registered name of the component.
@@ -15,4 +20,4 @@ protected static function getFacadeAccessor()
     {
         return 'infinite-scroll';
     }
-}
+}

src/InfiniteScroll.php

@@ -1,34 +1,34 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Codelabmw\InfiniteScroll;
 
+use Codelabmw\InfiniteScroll\Enums\PaginationType;
 use Illuminate\Contracts\Pagination\CursorPaginator;
 use Illuminate\Contracts\Pagination\Paginator;
 use Illuminate\Database\Eloquent\Builder;
 use Inertia\Inertia;
-use Codelabmw\InfiniteScroll\Enums\PaginationType;
 
-class InfiniteScroll
+final class InfiniteScroll
 {
     /**
      * Sets up infinite scrolling props for a given query.
-     * 
-     * @param string $key
-     * @param Builder|CursorPaginator|Paginator $paginator
-     * @param int $perPage
-     * @param array<int, string> $columns
-     * 
+     *
+     * @param  array<int, string>  $columns
      * @return array<string, mixed>
+     *
+     * @phpstan-ignore-next-line missingType.generics
      */
     public function make(string $key, Builder|CursorPaginator|Paginator $paginator, int $perPage = 15, array $columns = ['*']): array
     {
         if ($paginator instanceof Paginator) {
             return [
-                $key => Inertia::defer(fn() => $paginator->items())->deepMerge(),
-                'type' => fn() => PaginationType::PAGED,
-                'page' => fn() => $paginator->currentPage(),
-                'hasMore' => fn() => $paginator->hasMorePages(),
-                'perPage' => fn() => $perPage,
+                $key => Inertia::defer(fn () => $paginator->items())->deepMerge(),
+                'type' => fn (): PaginationType => PaginationType::PAGED,
+                'page' => fn () => $paginator->currentPage(),
+                'hasMore' => fn () => $paginator->hasMorePages(),
+                'perPage' => fn (): int => $perPage,
             ];
         }
 
@@ -37,11 +37,11 @@ public function make(string $key, Builder|CursorPaginator|Paginator $paginator,
         }
 
         return [
-            $key => Inertia::defer(fn() => $paginator->items())->deepMerge(),
-            'type' => fn() => PaginationType::CURSOR,
-            'cursor' => fn() => $paginator->nextCursor()?->encode(),
-            'hasMore' => fn() => $paginator->hasMorePages(),
-            'perPage' => fn() => $perPage,
+            $key => Inertia::defer(fn () => $paginator->items())->deepMerge(),
+            'type' => fn (): PaginationType => PaginationType::CURSOR,
+            'cursor' => fn () => $paginator->nextCursor()?->encode(),
+            'hasMore' => fn () => $paginator->hasMorePages(), // @phpstan-ignore-line method.notFound
+            'perPage' => fn (): int => $perPage,
         ];
     }
-}
+}

src/InfiniteScrollServiceProvider.php

@@ -5,7 +5,6 @@
 namespace Codelabmw\InfiniteScroll;
 
 use Illuminate\Support\ServiceProvider;
-use Inertia\Inertia;
 
 final class InfiniteScrollServiceProvider extends ServiceProvider
 {
@@ -14,7 +13,7 @@ final class InfiniteScrollServiceProvider extends ServiceProvider
      */
     public function register(): void
     {
-        $this->app->bind('infinite-scroll', fn() => new InfiniteScroll());
+        $this->app->bind('infinite-scroll', fn (): InfiniteScroll => new InfiniteScroll());
     }
 
     /**

tests/Fixtures/TestModel.php

@@ -1,15 +1,17 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Codelabmw\Tests\Fixtures;
 
 use Illuminate\Database\Eloquent\Factories\HasFactory;
 use Illuminate\Database\Eloquent\Model;
 
-class TestModel extends Model
+final class TestModel extends Model
 {
     /** @uses HasFactory<\Codelabmw\InfiniteScroll\Database\Factories\TestModelFactory> */
     use HasFactory;
 
     /** @var array<string, mixed> */
     protected $guarded = [];
-}
+}

tests/Unit/InfiniteScrollTest.php

@@ -1,17 +1,18 @@
 <?php
 
+declare(strict_types=1);
+
 use Codelabmw\InfiniteScroll\Enums\PaginationType;
 use Codelabmw\InfiniteScroll\Facades\InfiniteScroll;
 use Codelabmw\Tests\Fixtures\TestModel;
 use Inertia\DeferProp;
 
-beforeEach(function () {
+beforeEach(function (): void {
     // Arrange
     TestModel::factory()->count(20)->create();
-})->only();
-
+});
 
-test('returns cursor pagination data given query', function () {
+test('returns cursor pagination data given query', function (): void {
     // Act
     $result = InfiniteScroll::make('test', TestModel::query());
 
@@ -25,7 +26,7 @@
     expect($result['perPage']())->toBeInt();
 });
 
-test('returns cursor pagination data given cursor object', function () {
+test('returns cursor pagination data given cursor object', function (): void {
     // Act
     $result = InfiniteScroll::make('test', TestModel::query()->cursorPaginate());
 
@@ -39,7 +40,7 @@
     expect($result['perPage']())->toBeInt();
 });
 
-test('returns pagination data given a pagination object', function () {
+test('returns pagination data given a pagination object', function (): void {
     // Act
     $result = InfiniteScroll::make('test', TestModel::query()->paginate());
 
@@ -53,7 +54,7 @@
     expect($result['perPage']())->toBeInt();
 });
 
-test('returns pagination data given a simple pagination object', function () {
+test('returns pagination data given a simple pagination object', function (): void {
     // Act
     $result = InfiniteScroll::make('test', TestModel::query()->simplePaginate());
 
@@ -65,4 +66,4 @@
     expect($result['page']())->toBeInt();
     expect($result['hasMore']())->toBeTrue();
     expect($result['perPage']())->toBeInt();
-});
+});