test: remove unneeded assertSame()

kenjis · kenjis · commit b0e632959674 · 2024-07-02T11:32:46.000+09:00
PHPStan reports false positive because of this code.
diff --git a/tests/libaries/GitHubTest.php b/tests/libaries/GitHubTest.php
@@ -93,14 +93,12 @@ public function testServiceUsesConfig()
 
     public function testLiveUsesCache()
     {
-        $this->assertSame([], cache()->getCacheInfo());
-
         $github = service('github', null, null, false);
         $github->getCommit(['bcit-ci', 'CodeIgniter', '0199f68db46d375af2d4cb831c679d3040601f25']);
 
         $result = cache()->getCacheInfo();
 
-        $this->assertNotSame([], $result); // @phpstan-ignore-line
+        $this->assertNotSame([], $result);
         $this->assertCount(1, $result);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -93,14 +93,12 @@ public function testServiceUsesConfig()`
`93`	`93`
`94`	`94`	`public function testLiveUsesCache()`
`95`	`95`	`{`
`96`		`- $this->assertSame([], cache()->getCacheInfo());`
`97`		`-`
`98`	`96`	`$github = service('github', null, null, false);`
`99`	`97`	`$github->getCommit(['bcit-ci', 'CodeIgniter', '0199f68db46d375af2d4cb831c679d3040601f25']);`
`100`	`98`
`101`	`99`	`$result = cache()->getCacheInfo();`
`102`	`100`
`103`		`- $this->assertNotSame([], $result); // @phpstan-ignore-line`
	`101`	`+ $this->assertNotSame([], $result);`
`104`	`102`	`$this->assertCount(1, $result);`
`105`	`103`	`}`
`106`	`104`