Rector 0.9 fixes (#4196)

Author: paulbalandan

composer.json

@@ -18,7 +18,7 @@
 		"codeigniter4/codeigniter4-standard": "^1.0",
 		"fakerphp/faker": "^1.9",
 		"mikey179/vfsstream": "^1.6",
-		"phpstan/phpstan": "^0.12",
+		"phpstan/phpstan": "0.12.69",
 		"phpunit/phpunit": "^9.1",
 		"predis/predis": "^1.1",
 		"rector/rector": "^0.9",

system/Database/BaseBuilder.php

@@ -2226,8 +2226,6 @@ public function getCompiledInsert(bool $reset = true)
 		return $this->compileFinalQuery($sql);
 	}
 
-	//--------------------------------------------------------------------
-
 	/**
 	 * Insert
 	 *
@@ -2319,8 +2317,6 @@ protected function _insert(string $table, array $keys, array $unescapedKeys): st
 		return 'INSERT ' . $this->compileIgnore('insert') . 'INTO ' . $table . ' (' . implode(', ', $keys) . ') VALUES (' . implode(', ', $unescapedKeys) . ')';
 	}
 
-	//--------------------------------------------------------------------
-
 	/**
 	 * Replace
 	 *

system/Database/BaseConnection.php

@@ -592,8 +592,6 @@ public function addTableAlias(string $table)
 	 */
 	abstract protected function execute(string $sql);
 
-	//--------------------------------------------------------------------
-
 	/**
 	 * Orchestrates a query against the database. Queries must use
 	 * Database\Statement objects to store the query and build it.

system/Database/Config.php

@@ -103,8 +103,6 @@ public static function getConnections(): array
 		return static::$instances;
 	}
 
-	//--------------------------------------------------------------------
-
 	/**
 	 * Loads and returns an instance of the Forge for the specified
 	 * database group, and loads the group if it hasn't been loaded yet.

system/Database/Forge.php

@@ -453,8 +453,6 @@ public function addForeignKey(string $fieldName = '', string $tableName = '', st
 		return $this;
 	}
 
-	//--------------------------------------------------------------------
-
 	/**
 	 * Foreign Key Drop
 	 *

system/Database/MigrationRunner.php

@@ -119,8 +119,6 @@ class MigrationRunner
 	 */
 	protected $groupSkip = false;
 
-	//--------------------------------------------------------------------
-
 	/**
 	 * Constructor.
 	 *

system/HTTP/Files/FileCollection.php

@@ -47,8 +47,6 @@ public function all()
 		return $this->files;
 	}
 
-	//--------------------------------------------------------------------
-
 	/**
 	 * Attempts to get a single file from the collection of uploaded files.
 	 *
@@ -182,8 +180,6 @@ protected function populateFiles()
 		}
 	}
 
-	//--------------------------------------------------------------------
-
 	/**
 	 * Given a file array, will create UploadedFile instances. Will
 	 * loop over an array and create objects for each.

system/HTTP/Message.php

@@ -58,7 +58,7 @@ public function getBody()
 	/**
 	 * Returns an array containing all headers.
 	 *
-	 * @return array<string,Header> An array of the request headers
+	 * @return array<string, Header> An array of the request headers
 	 *
 	 * @deprecated Use Message::headers() to make room for PSR-7
 	 */
@@ -140,7 +140,7 @@ public function getProtocolVersion(): string
 	 *
 	 * @deprecated Use header calls directly
 	 */
-      public function isJSON()
+	public function isJSON()
 	{
 		if (! $this->hasHeader('Content-Type'))
 		{

system/HTTP/MessageInterface.php

@@ -44,7 +44,7 @@ public function populateHeaders(): void;
 	/**
 	 * Returns an array containing all Headers.
 	 *
-	 * @return array<string,Header> An array of the Header objects
+	 * @return array<string, Header> An array of the Header objects
 	 */
 	public function headers(): array;
 

system/HTTP/MessageTrait.php

@@ -25,7 +25,7 @@ trait MessageTrait
 	/**
 	 * List of all HTTP request headers.
 	 *
-	 * @var array<string,Header>
+	 * @var array<string, Header>
 	 */
 	protected $headers = [];
 
@@ -105,7 +105,7 @@ public function populateHeaders(): void
 	/**
 	 * Returns an array containing all Headers.
 	 *
-	 * @return array<string,Header> An array of the Header objects
+	 * @return array<string, Header> An array of the Header objects
 	 */
 	public function headers(): array
 	{