fix: TypeError in less_than and less_than_equal_to

Author: kenjis

system/Validation/StrictRules/Rules.php

@@ -149,20 +149,28 @@ public function is_unique($str, string $field, array $data): bool
     /**
      * Less than
      *
-     * @param mixed $str
+     * @param mixed $str expects int|string
      */
     public function less_than($str, string $max): bool
     {
+        if (is_int($str)) {
+            $str = (string) $str;
+        }
+
         return $this->nonStrictRules->less_than($str, $max);
     }
 
     /**
      * Equal to or Less than
      *
-     * @param mixed $str
+     * @param mixed $str expects int|string
      */
     public function less_than_equal_to($str, string $max): bool
     {
+        if (is_int($str)) {
+            $str = (string) $str;
+        }
+
         return $this->nonStrictRules->less_than_equal_to($str, $max);
     }
 

tests/system/Validation/StrictRules/RulesTest.php

@@ -129,4 +129,50 @@ public function provideGreaterThanStrict(): Generator
             [10, 'a', false],
         ];
     }
+
+    /**
+     * @dataProvider provideLessThanStrict
+     *
+     * @param int $value
+     */
+    public function testLessThanStrict($value, string $param, bool $expected): void
+    {
+        $this->validation->setRules(['foo' => "less_than[{$param}]"]);
+
+        $data = ['foo' => $value];
+        $this->assertSame($expected, $this->validation->run($data));
+    }
+
+    public function provideLessThanStrict(): Generator
+    {
+        yield from [
+            [-10, '-11', false],
+            [9, '10', true],
+            [10, '9', false],
+            [10, '10', false],
+            [10, 'a', true],
+        ];
+    }
+
+    /**
+     * @dataProvider provideLessThanEqualStrict
+     *
+     * @param int $value
+     */
+    public function testLessEqualThanStrict($value, ?string $param, bool $expected): void
+    {
+        $this->validation->setRules(['foo' => "less_than_equal_to[{$param}]"]);
+
+        $data = ['foo' => $value];
+        $this->assertSame($expected, $this->validation->run($data));
+    }
+
+    public function provideLessThanEqualStrict(): Generator
+    {
+        yield from [
+            [0, '0', true],
+            [1, '0', false],
+            [-1, '0', true],
+        ];
+    }
 }