refactor: remove deprecations in Filters

Author: paulbalandan

system/Filters/Filters.php

@@ -125,26 +125,6 @@ class Filters
     protected array $filterClassInstances = [];
 
     /**
-     * Any arguments to be passed to filters.
-     *
-     * @var array<string, list<string>|null> [name => params]
-     *
-     * @deprecated 4.6.0 No longer used.
-     */
-    protected $arguments = [];
-
-    /**
-     * Any arguments to be passed to filtersClass.
-     *
-     * @var array<class-string, list<string>|null> [classname => arguments]
-     *
-     * @deprecated 4.6.0 No longer used.
-     */
-    protected $argumentsClass = [];
-
-    /**
-     * Constructor.
-     *
      * @param FiltersConfig $config
      */
     public function __construct($config, RequestInterface $request, ResponseInterface $response, ?Modules $modules = null)
@@ -154,42 +134,6 @@ public function __construct($config, RequestInterface $request, ResponseInterfac
         $this->setResponse($response);
 
         $this->modules = $modules instanceof Modules ? $modules : new Modules();
-
-        if ($this->modules->shouldDiscover('filters')) {
-            $this->discoverFilters();
-        }
-    }
-
-    /**
-     * If discoverFilters is enabled in Config then system will try to
-     * auto-discover custom filters files in namespaces and allow access to
-     * the config object via the variable $filters as with the routes file.
-     *
-     * Sample:
-     * $filters->aliases['custom-auth'] = \Acme\Blob\Filters\BlobAuth::class;
-     *
-     * @deprecated 4.4.2 Use Registrar instead.
-     */
-    private function discoverFilters(): void
-    {
-        $locator = service('locator');
-
-        // for access by custom filters
-        $filters = $this->config;
-
-        $files = $locator->search('Config/Filters.php');
-
-        foreach ($files as $file) {
-            // The $file may not be a class file.
-            $className = $locator->getClassname($file);
-
-            // Don't include our main Filter config again...
-            if ($className === FiltersConfig::class || $className === BaseFiltersConfig::class) {
-                continue;
-            }
-
-            include $file;
-        }
     }
 
     /**
@@ -501,8 +445,6 @@ public function reset(): self
     {
         $this->initialized = false;
 
-        $this->arguments = $this->argumentsClass = [];
-
         $this->filters = $this->filtersClass = [
             'before' => [],
             'after'  => [],
@@ -644,18 +586,6 @@ public function enableFilters(array $filters, string $when = 'before')
         return $this;
     }
 
-    /**
-     * Returns the arguments for a specified key, or all.
-     *
-     * @return array<string, string>|string
-     *
-     * @deprecated 4.6.0 Already does not work.
-     */
-    public function getArguments(?string $key = null)
-    {
-        return ((string) $key === '') ? $this->arguments : $this->arguments[$key];
-    }
-
     // --------------------------------------------------------------------
     // Processors
     // --------------------------------------------------------------------
@@ -732,27 +662,9 @@ protected function processMethods()
 
         $method = $this->request->getMethod();
 
-        $found = false;
-
         if (array_key_exists($method, $this->config->methods)) {
-            $found = true;
-        }
-        // Checks lowercase HTTP method for backward compatibility.
-        // @deprecated 4.5.0
-        // @TODO remove this in the future.
-        elseif (array_key_exists(strtolower($method), $this->config->methods)) {
-            @trigger_error(
-                'Setting lowercase HTTP method key "' . strtolower($method) . '" is deprecated.'
-                . ' Use uppercase HTTP method like "' . strtoupper($method) . '".',
-                E_USER_DEPRECATED,
-            );
-
-            $found  = true;
-            $method = strtolower($method);
-        }
-
-        if ($found) {
             $oldFilterOrder = config(Feature::class)->oldFilterOrder ?? false;
+
             if ($oldFilterOrder) {
                 $this->filters['before'] = array_merge($this->filters['before'], $this->config->methods[$method]);
             } else {

tests/system/Filters/FiltersTest.php

@@ -443,46 +443,6 @@ public function testRunThrowsWithInvalidAlias(): void
         $filters->run($uri);
     }
 
-    public function testCustomFiltersLoad(): void
-    {
-        service('superglobals')->setServer('REQUEST_METHOD', 'GET');
-
-        $config = [
-            'aliases' => [],
-            'globals' => [
-                'before' => ['test-customfilter'],
-                'after'  => [],
-            ],
-        ];
-        $filtersConfig = $this->createConfigFromArray(FiltersConfig::class, $config);
-        $filters       = $this->createFilters($filtersConfig);
-
-        $uri     = 'admin/foo/bar';
-        $request = $filters->run($uri, 'before');
-
-        $this->assertSame('http://hellowworld.com', $request->getBody());
-
-        $this->resetServices();
-    }
-
-    /**
-     * @see https://github.com/codeigniter4/CodeIgniter4/issues/4720
-     */
-    public function testAllCustomFiltersAreDiscoveredInConstructor(): void
-    {
-        service('superglobals')->setServer('REQUEST_METHOD', 'GET');
-
-        $config = [
-            'aliases' => [],
-            'globals' => [],
-        ];
-        $filtersConfig = $this->createConfigFromArray(FiltersConfig::class, $config);
-        $filters       = $this->createFilters($filtersConfig);
-
-        $configFilters = $this->getPrivateProperty($filters, 'config');
-        $this->assertContains('test-customfilter', array_keys($configFilters->aliases));
-    }
-
     public function testRunThrowsWithInvalidClassType(): void
     {
         service('superglobals')->setServer('REQUEST_METHOD', 'GET');

user_guide_src/source/changelogs/v4.8.0.rst

@@ -23,6 +23,9 @@ BREAKING
 Behavior Changes
 ================
 
+- **Filters:** The deprecated case-insensitive checking of HTTP methods in ``processMethods()`` has been removed.
+- **Filters:** The deprecated auto-discovery of custom filters has been removed. Custom filters must now be explicitly defined in Registrars.
+
 Interface Changes
 =================
 
@@ -43,6 +46,11 @@ Removed Deprecated Items
     - ``CodeIgniter\Debug\Exceptions::cleanPath()``
     - ``CodeIgniter\Debug\Exceptions::describeMemory()``
     - ``CodeIgniter\Debug\Exceptions::highlightFile()``
+- **Filters:** Removed the following properties and methods deprecated:
+    - ``CodeIgniter\Filters\Filters::$arguments`` (deprecated since v4.6.0)
+    - ``CodeIgniter\Filters\Filters::$argumentsClass`` (deprecated since v4.6.0)
+    - ``CodeIgniter\Filters\Filters::getArguments()`` (deprecated since v4.6.0)
+    - ``CodeIgniter\Filters\Filters::discoverFilters()`` (deprecated since v4.4.2)
 
 ************
 Enhancements

user_guide_src/source/general/modules.rst

@@ -160,28 +160,6 @@ the **Modules** config file, described above.
 When working with modules, it can be a problem if the routes in the application contain wildcards.
 In that case, see :ref:`routing-priority`.
 
-.. _modules-filters:
-
-Filters
-=======
-
-.. deprecated:: 4.4.2
-
-.. note:: This feature is deprecated. Use :ref:`registrars` instead like the
-    following:
-
-    .. literalinclude:: modules/015.php
-
-By default, :doc:`filters <../incoming/filters>` are automatically scanned for within modules.
-It can be turned off in the **Modules** config file, described above.
-
-.. note:: Since the files are being included into the current scope, the ``$filters`` instance is already defined for you.
-    It will cause errors if you attempt to redefine that class.
-
-In the module's **Config/Filters.php** file, you need to define the aliases of the filters you use:
-
-.. literalinclude:: modules/005.php
-
 Controllers
 ===========