Set WarningsReturnAsErrors = 0 before connection (#4762)

obelisk-services · web-flow · commit 8fbba76346ad · 2021-06-03T02:18:49.000+08:00
* Set WarningsReturnAsErrors = 0 before connection

If there is a warning establishing the connection, it will treat it as an error and Codeigniter will throw an exception. It should be configured prior the first sql command.

* Removed extra whitespace
diff --git a/system/Database/SQLSRV/Connection.php b/system/Database/SQLSRV/Connection.php
@@ -129,12 +129,11 @@ public function connect(bool $persistent = false)
 			unset($connection['UID'], $connection['PWD']);
 		}
 
+		sqlsrv_configure('WarningsReturnAsErrors', 0);
 		$this->connID = sqlsrv_connect($this->hostname, $connection);
 
 		if ($this->connID !== false)
 		{
-			sqlsrv_configure('WarningsReturnAsErrors', 0);
-
 			// Determine how identifiers are escaped
 			$query = $this->query('SELECT CASE WHEN (@@OPTIONS | 256) = @@OPTIONS THEN 1 ELSE 0 END AS qi');
 			$query = $query->getResultObject();

Original file line number	Diff line number	Diff line change
`@@ -129,12 +129,11 @@ public function connect(bool $persistent = false)`
`129`	`129`	`unset($connection['UID'], $connection['PWD']);`
`130`	`130`	`}`
`131`	`131`
	`132`	`+ sqlsrv_configure('WarningsReturnAsErrors', 0);`
`132`	`133`	`$this->connID = sqlsrv_connect($this->hostname, $connection);`
`133`	`134`
`134`	`135`	`if ($this->connID !== false)`
`135`	`136`	`{`
`136`		`- sqlsrv_configure('WarningsReturnAsErrors', 0);`
`137`		`-`
`138`	`137`	`// Determine how identifiers are escaped`
`139`	`138`	`$query = $this->query('SELECT CASE WHEN (@@OPTIONS \| 256) = @@OPTIONS THEN 1 ELSE 0 END AS qi');`
`140`	`139`	`$query = $query->getResultObject();`