Add starter health check (baseUrl)

Author: MGatner

admin/starter/tests/_support/Libraries/ConfigReader.php

@@ -0,0 +1,55 @@
+<?php
+
+
+/**
+ * CodeIgniter
+ *
+ * An open source application development framework for PHP
+ *
+ * This content is released under the MIT License (MIT)
+ *
+ * Copyright (c) 2014-2019 British Columbia Institute of Technology
+ * Copyright (c) 2019-2020 CodeIgniter Foundation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ *
+ * @package    CodeIgniter
+ * @author     CodeIgniter Dev Team
+ * @copyright  2019-2020 CodeIgniter Foundation
+ * @license    https://opensource.org/licenses/MIT	MIT License
+ * @link       https://codeigniter.com
+ * @since      Version 4.0.0
+ * @filesource
+ */
+
+namespace Tests\Support\Libraries;
+
+/**
+ * Class ConfigReader
+ *
+ * An extension of BaseConfig that prevents the constructor from
+ * loading external values. Used to read actual local values from
+ * a config file.
+ */
+class ConfigReader extends \App\Config\App
+{
+	public function __construct()
+	{
+	}
+}

admin/starter/tests/unit/ExampleTest.php

@@ -20,15 +20,15 @@ public function testBaseUrlHasBeenSet()
 
 		// First check in .env
 		$dotenv = new \CodeIgniter\Config\DotEnv(HOMEPATH);
-
-		if ($dotenv->load())
+		if ($vars = $dotenv->parse())
 		{
-			// Check any line with "app.baseUrl" to see if it actually has a value set
-			foreach (preg_grep('/^app\.baseURL', file(HOMEPATH . '.env')) as $line)
-			{
-			}
+			$env = ! empty($vars['app.baseUrl']);
 		}
 
-		$this->assertTrue($test);
+		// Then check the actual config file
+		$reader = new \Tests\Support\Libraries\ConfigReader();
+		$config = ! empty($reader->baseUrl);
+
+		$this->assertTrue($env || $config);
 	}
 }