Merge pull request #4065 from MGatner/phpstan-8

MGatner · web-flow · commit 5a8e7571bf84 · 2021-01-05T11:49:32.000-05:00
PHPStan Ignore File
diff --git a/.github/workflows/test-phpstan.yml b/.github/workflows/test-phpstan.yml
@@ -10,13 +10,15 @@ on:
     paths:
       - 'app/**'
       - 'system/**'
+      - phpstan.neon.dist
   push:
     branches:
       - 'develop'
       - '4.*'
     paths:
       - 'app/**'
       - 'system/**'
+      - phpstan.neon.dist
 
 jobs:
   build:
diff --git a/phpstan.neon.dist b/phpstan.neon.dist
@@ -25,6 +25,7 @@ parameters:
 		- system/Config/Routes.php
 		- system/Debug/Toolbar/Views/toolbar.tpl.php
 		- system/Images/Handlers/GDHandler.php
+		- system/Test/Filters/CITestStreamFilter.php
 		- system/ThirdParty/*
 		- system/Validation/Views/single.php
 	ignoreErrors:
diff --git a/system/Test/Filters/CITestStreamFilter.php b/system/Test/Filters/CITestStreamFilter.php
@@ -46,7 +46,6 @@ public function filter($in, $out, &$consumed, $closing)
 			$consumed += $bucket->datalen;
 		}
 
-		// @phpstan-ignore-next-line
 		return PSFS_PASS_ON;
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,6 @@ public function filter($in, $out, &$consumed, $closing)`
`46`	`46`	`$consumed += $bucket->datalen;`
`47`	`47`	`}`
`48`	`48`
`49`		`- // @phpstan-ignore-next-line`
`50`	`49`	`return PSFS_PASS_ON;`
`51`	`50`	`}`
`52`	`51`	`}`