Skip to content

Commit 9acaeb5

Browse files
JunyiXu-nvcodego7250
authored andcommitted
[https://nvbugs/5703953][fix] Use random port for disagg tests (NVIDIA#9582)
Signed-off-by: Junyi Xu <219237550+JunyiXu-nv@users.noreply.github.com>
1 parent 06d767c commit 9acaeb5

File tree

1 file changed

+11
-28
lines changed

1 file changed

+11
-28
lines changed

tests/integration/defs/accuracy/test_disaggregated_serving.py

Lines changed: 11 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import requests
1515
import yaml
1616

17+
from tensorrt_llm._utils import get_free_port
1718
from tensorrt_llm.executor.result import GenerationResultBase
1819
from tensorrt_llm.llmapi import CompletionOutput, RequestOutput, SamplingParams
1920
from tensorrt_llm.llmapi.llm_args import LlmArgs
@@ -67,37 +68,19 @@ def __exit__(self, exc_type, exc_val, exc_tb):
6768
return False
6869

6970

70-
def check_port_available(port: int) -> int:
71-
import socket
72-
try:
73-
with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as s:
74-
s.bind(('localhost', port))
75-
return port
76-
except socket.error:
77-
# find a free port
78-
sock = socket.socket()
79-
sock.bind(('', 0))
80-
return sock.getsockname()[1]
81-
82-
8371
def revise_disaggregated_server_config_urls_with_free_ports(
8472
disaggregated_server_config: Dict[str, Any]) -> Dict[str, Any]:
85-
disaggregated_server_config['port'] = check_port_available(
86-
disaggregated_server_config['port'])
87-
ctx_urls = disaggregated_server_config["context_servers"]["urls"]
88-
gen_urls = disaggregated_server_config["generation_servers"]["urls"]
73+
num_ctx_ports = len(disaggregated_server_config["context_servers"]["urls"])
74+
num_gen_ports = len(
75+
disaggregated_server_config["generation_servers"]["urls"])
8976

90-
new_ctx_urls = []
91-
new_gen_urls = []
92-
for url in ctx_urls:
93-
port = check_port_available(int(url.split(":")[1]))
94-
new_ctx_urls.append(f"localhost:{port}")
95-
for url in gen_urls:
96-
port = check_port_available(int(url.split(":")[1]))
97-
new_gen_urls.append(f"localhost:{port}")
98-
99-
disaggregated_server_config["context_servers"]["urls"] = new_ctx_urls
100-
disaggregated_server_config["generation_servers"]["urls"] = new_gen_urls
77+
disaggregated_server_config['port'] = get_free_port()
78+
disaggregated_server_config["context_servers"]["urls"] = [
79+
f"localhost:{get_free_port()}" for _ in range(num_ctx_ports)
80+
]
81+
disaggregated_server_config["generation_servers"]["urls"] = [
82+
f"localhost:{get_free_port()}" for _ in range(num_gen_ports)
83+
]
10184

10285
return disaggregated_server_config
10386

0 commit comments

Comments
 (0)