Skip to content

Commit f3a2cb8

Browse files
VasylMarchukVasylMarchuk
committed
Override ember-cli-mirage initializer & fix mirage config to fix npm run start:fastboot 
1 parent 24d9efa commit f3a2cb8

File tree

2 files changed

+128
-45
lines changed

2 files changed

+128
-45
lines changed

‎app/initializers/ember-cli-mirage.js‎

Lines changed: 74 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,74 @@
1+
/**
2+
* This initializer has been copied from the original ember-cli-mirage initializer
3+
* and patched to properly support FastBoot, with the following changes:
4+
*
5+
* - `initializer` made async
6+
* - `makeServer` imported from `mirage/config` is now async
7+
* - `makeServer` now uses `await import(...)` to _conditionally_ import mirage
8+
* modules, depending on whether FastBoot is present
9+
*
10+
* Source: https://github.com/miragejs/ember-cli-mirage/blob/21412d882c37c8602a66431d48ee182b3434f07d/packages/ember-cli-mirage/app/initializers/ember-cli-mirage.js
11+
*/
12+
13+
import ENV from 'codecrafters-frontend/config/environment';
14+
import getRfc232TestContext from 'ember-cli-mirage/get-rfc232-test-context';
15+
import startMirageImpl from 'ember-cli-mirage/start-mirage';
16+
import makeServer from 'codecrafters-frontend/mirage/config';
17+
18+
//
19+
// This initializer does two things:
20+
//
21+
// 1. Pulls the mirage config objects from the application's config and
22+
// registers them in the container so `ember-cli-mirage/start-mirage` can
23+
// find them (since it doesn't have access to the app's namespace).
24+
// 2. Provides legacy support for auto-starting mirage in pre-rfc268 acceptance
25+
// tests.
26+
//
27+
export default {
28+
name: 'ember-cli-mirage',
29+
async initialize(application) {
30+
const makeServerResult = await makeServer();
31+
32+
if (makeServerResult) {
33+
application.register('mirage:make-server', makeServerResult, {
34+
instantiate: false,
35+
});
36+
}
37+
38+
ENV['ember-cli-mirage'] = ENV['ember-cli-mirage'] || {};
39+
40+
if (_shouldUseMirage(ENV.environment, ENV['ember-cli-mirage'])) {
41+
startMirage(application.__container__, makeServerResult, ENV);
42+
}
43+
},
44+
};
45+
46+
function startMirage(owner, makeServer, env = ENV) {
47+
return startMirageImpl(owner, { env, makeServer });
48+
}
49+
50+
function _shouldUseMirage(env, addonConfig) {
51+
if (typeof FastBoot !== 'undefined') {
52+
return false;
53+
}
54+
55+
if (getRfc232TestContext()) {
56+
return false;
57+
}
58+
59+
let userDeclaredEnabled = typeof addonConfig.enabled !== 'undefined';
60+
let defaultEnabled = _defaultEnabled(env, addonConfig);
61+
62+
return userDeclaredEnabled ? addonConfig.enabled : defaultEnabled;
63+
}
64+
65+
/*
66+
Returns a boolean specifying the default behavior for whether
67+
to initialize Mirage.
68+
*/
69+
function _defaultEnabled(env, addonConfig) {
70+
let usingInDev = env === 'development' && !addonConfig.usingProxy;
71+
let usingInTest = env === 'test';
72+
73+
return usingInDev || usingInTest;
74+
}

‎mirage/config.js‎

Lines changed: 54 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import { Model, belongsTo, createServer, hasMany } from 'miragejs';
2+
import config from 'codecrafters-frontend/config/environment';
13
import affiliateEarningsPayouts from './handlers/affiliate-earnings-payouts';
24
import affiliateLinks from './handlers/affiliate-links';
35
import affiliateReferrals from './handlers/affiliate-referrals';
@@ -16,7 +18,6 @@ import conceptEngagements from './handlers/concept-engagements';
1618
import conceptGroups from './handlers/concept-groups';
1719
import conceptQuestions from './handlers/concept-questions';
1820
import concepts from './handlers/concepts';
19-
import config from 'codecrafters-frontend/config/environment';
2021
import contests from './handlers/contests';
2122
import courseDefinitionUpdates from './handlers/course-definition-updates';
2223
import courseExtensionActivations from './handlers/course-extension-activations';
@@ -69,53 +70,61 @@ import trustedCommunitySolutionEvaluations from './handlers/trusted-community-so
6970
import upvotes from './handlers/upvotes';
7071
import users from './handlers/users';
7172
import views from './handlers/views';
72-
import { Model, belongsTo, createServer, hasMany } from 'miragejs';
73-
import { applyEmberDataSerializers, discoverEmberDataModels } from 'ember-cli-mirage';
7473

75-
export default function (config) {
76-
let finalConfig = {
77-
...config,
78-
models: {
79-
...discoverEmberDataModels(config.store),
80-
...config.models,
81-
...{
82-
courseStageComment: Model.extend({
83-
user: belongsTo('user', { inverse: null }),
84-
target: belongsTo('course-stage', { inverse: 'comments' }),
85-
language: belongsTo('language', { inverse: null }),
86-
currentUserDownvotes: hasMany('downvote', { inverse: 'downvotable' }),
87-
currentUserUpvotes: hasMany('upvote', { inverse: 'upvotable' }),
88-
parentComment: belongsTo('course-stage-comment', { inverse: null }),
89-
}),
90-
communityCourseStageSolution: Model.extend({
91-
comments: hasMany('community-course-stage-solution-comment', { inverse: 'target' }),
92-
courseStage: belongsTo('course-stage', { inverse: 'communitySolutions' }),
93-
currentUserDownvotes: hasMany('downvote', { inverse: 'downvotable' }),
94-
currentUserUpvotes: hasMany('upvote', { inverse: 'upvotable' }),
95-
evaluations: hasMany('community-solution-evaluation', { inverse: 'communitySolution' }),
96-
exports: hasMany('community-solution-export', { inverse: 'communitySolution' }),
97-
language: belongsTo('language', { inverse: null }),
98-
screencasts: hasMany('course-stage-screencast', { inverse: 'solution' }),
99-
trustedEvaluations: hasMany('trusted-community-solution-evaluation', { inverse: 'communitySolution' }),
100-
user: belongsTo('user', { inverse: null }),
101-
}),
102-
communityCourseStageSolutionComment: Model.extend({
103-
user: belongsTo('user', { inverse: null }),
104-
target: belongsTo('community-course-stage-solution', { inverse: 'comments' }),
105-
language: belongsTo('language', { inverse: null }),
106-
currentUserDownvotes: hasMany('downvote', { inverse: 'downvotable' }),
107-
currentUserUpvotes: hasMany('upvote', { inverse: 'upvotable' }),
108-
parentComment: belongsTo('community-course-stage-solution-comment', { inverse: null }),
109-
}),
110-
fakeLogstream: Model.extend({}),
74+
export default async function () {
75+
if (typeof FastBoot !== 'undefined') {
76+
return;
77+
}
78+
79+
// This import MUST NOT happen under FastBoot, otherwise it'll cause major
80+
// errors when running `npm run start:fastboot`
81+
const { applyEmberDataSerializers, discoverEmberDataModels } = await import('ember-cli-mirage');
82+
83+
return function (config) {
84+
const finalConfig = {
85+
...config,
86+
models: {
87+
...discoverEmberDataModels(config.store),
88+
...config.models,
89+
...{
90+
courseStageComment: Model.extend({
91+
user: belongsTo('user', { inverse: null }),
92+
target: belongsTo('course-stage', { inverse: 'comments' }),
93+
language: belongsTo('language', { inverse: null }),
94+
currentUserDownvotes: hasMany('downvote', { inverse: 'downvotable' }),
95+
currentUserUpvotes: hasMany('upvote', { inverse: 'upvotable' }),
96+
parentComment: belongsTo('course-stage-comment', { inverse: null }),
97+
}),
98+
communityCourseStageSolution: Model.extend({
99+
comments: hasMany('community-course-stage-solution-comment', { inverse: 'target' }),
100+
courseStage: belongsTo('course-stage', { inverse: 'communitySolutions' }),
101+
currentUserDownvotes: hasMany('downvote', { inverse: 'downvotable' }),
102+
currentUserUpvotes: hasMany('upvote', { inverse: 'upvotable' }),
103+
evaluations: hasMany('community-solution-evaluation', { inverse: 'communitySolution' }),
104+
exports: hasMany('community-solution-export', { inverse: 'communitySolution' }),
105+
language: belongsTo('language', { inverse: null }),
106+
screencasts: hasMany('course-stage-screencast', { inverse: 'solution' }),
107+
trustedEvaluations: hasMany('trusted-community-solution-evaluation', { inverse: 'communitySolution' }),
108+
user: belongsTo('user', { inverse: null }),
109+
}),
110+
communityCourseStageSolutionComment: Model.extend({
111+
user: belongsTo('user', { inverse: null }),
112+
target: belongsTo('community-course-stage-solution', { inverse: 'comments' }),
113+
language: belongsTo('language', { inverse: null }),
114+
currentUserDownvotes: hasMany('downvote', { inverse: 'downvotable' }),
115+
currentUserUpvotes: hasMany('upvote', { inverse: 'upvotable' }),
116+
parentComment: belongsTo('community-course-stage-solution-comment', { inverse: null }),
117+
}),
118+
fakeLogstream: Model.extend({}),
119+
},
111120
},
112-
},
113-
serializers: applyEmberDataSerializers(config.serializers),
114-
routes,
115-
trackRequests: config.environment === 'test',
116-
};
121+
serializers: applyEmberDataSerializers(config.serializers),
122+
routes,
123+
trackRequests: config.environment === 'test',
124+
};
117125

118-
return createServer(finalConfig);
126+
return createServer(finalConfig);
127+
};
119128
}
120129

121130
function routes() {

0 commit comments

Comments
 (0)