Merge pull request #3244 from codecrafters-io/andy/tweak

andy1li · web-flow · commit a31afbe17107 · 2025-11-04T15:33:04.000+08:00
Open course admin submissions in a new tab instead of transitioning
diff --git a/app/components/course-page/repository-dropdown/index.ts b/app/components/course-page/repository-dropdown/index.ts
@@ -44,7 +44,7 @@ export default class CoursePageRepositoryDropdown extends Component<Signature> {
   @action
   async handleAdminButtonClick(dropdownActions: { close: () => void }) {
     dropdownActions.close();
-    this.router.transitionTo('course-admin.submissions', this.args.activeRepository.course.slug);
+    window.open(this.router.urlFor('course-admin.submissions', this.args.activeRepository.course.slug), '_blank');
   }
 
   @action

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ export default class CoursePageRepositoryDropdown extends Component<Signature> {`
`44`	`44`	`@action`
`45`	`45`	`async handleAdminButtonClick(dropdownActions: { close: () => void }) {`
`46`	`46`	`dropdownActions.close();`
`47`		`- this.router.transitionTo('course-admin.submissions', this.args.activeRepository.course.slug);`
	`47`	`+ window.open(this.router.urlFor('course-admin.submissions', this.args.activeRepository.course.slug), '_blank');`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`@action`