Skip to content

Commit d71afb0

Browse files
authored
Fix #90 - booleans in subnet module aren't working (#91)
* Fix #90 - booleans in subnet module aren't working Camelize key with no uppercase first letter. * fix test values * add changelog entry
1 parent 4d6e6b7 commit d71afb0

File tree

3 files changed

+18
-1
lines changed

3 files changed

+18
-1
lines changed
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
bugfixes:
2+
- fix \#90 - booleans in subnet module aren't working

plugins/module_utils/phpipam_helper.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,7 @@ def _phpipam_spec_helper(self, spec):
341341
ansible_invisible = value.get('invisible', False)
342342

343343
if 'phpipam_name' not in phpipam_value and '_' in key:
344-
phpipam_value['phpipam_name'] = inflection.camelize(key)
344+
phpipam_value['phpipam_name'] = inflection.camelize(key, uppercase_first_letter=False)
345345

346346
if phpipam_type == 'entity':
347347
argument_value['type'] = 'str'

tests/test_playbooks/subnet.yml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,21 @@
1919
name: create subnet again, no change
2020
subnet: "{{ base_subnet_data }}"
2121

22+
- name: set booleans
23+
include: tasks/subnet.yml
24+
vars:
25+
name: set booleans
26+
override:
27+
show_as_name: Yes
28+
dns_recursive: Yes
29+
dns_records: Yes
30+
allow_requests: Yes
31+
ping_subnet: Yes
32+
discover_subnet: Yes
33+
is_folder: No
34+
is_full: No
35+
subnet: "{{ base_subnet_data | combine(override) }}"
36+
2237
- name: delete subnet
2338
include: tasks/subnet.yml
2439
vars:

0 commit comments

Comments
 (0)