restore constants

Author: Thomas Stromberg

pkg/prx/client_graphql.go

@@ -142,7 +142,7 @@ func (c *Client) fetchCheckRunsREST(ctx context.Context, owner, repo, sha string
 		}
 
 		event := Event{
-			Kind:      "check_run",
+			Kind:      EventKindCheckRun,
 			Timestamp: timestamp,
 			Actor:     "github",
 			Bot:       true,
@@ -184,7 +184,7 @@ func (c *Client) fetchAllCheckRunsREST(ctx context.Context, owner, repo string,
 	// Add all other commit SHAs from commit events
 	for i := range prData.Events {
 		e := &prData.Events[i]
-		if e.Kind == "commit" && e.Body != "" {
+		if e.Kind == EventKindCommit && e.Body != "" {
 			shas[e.Body] = true
 		}
 	}
@@ -222,7 +222,7 @@ func (*Client) existingRequiredChecks(prData *PullRequestData) []string {
 	// Extract from existing events that are marked as required
 	for i := range prData.Events {
 		e := &prData.Events[i]
-		if e.Required && (e.Kind == "check_run" || e.Kind == "status_check") {
+		if e.Required && (e.Kind == EventKindCheckRun || e.Kind == EventKindStatusCheck) {
 			required = append(required, e.Body)
 		}
 	}

pkg/prx/event_processing.go

@@ -12,7 +12,7 @@ func filterEvents(events []Event) []Event {
 	for i := range events {
 		e := &events[i]
 		// Include all non-status_check events
-		if e.Kind != "status_check" {
+		if e.Kind != EventKindStatusCheck {
 			filtered = append(filtered, *e)
 			continue
 		}
@@ -36,7 +36,8 @@ func upgradeWriteAccess(events []Event) {
 	for i := range events {
 		e := &events[i]
 		switch e.Kind {
-		case "pr_merged", "labeled", "unlabeled", "assigned", "unassigned", "milestoned", "demilestoned":
+		case EventKindPRMerged, EventKindLabeled, EventKindUnlabeled,
+			EventKindAssigned, EventKindUnassigned, EventKindMilestoned, EventKindDemilestoned:
 			// These actions require write access to the repository
 			if e.Actor != "" {
 				confirmed[e.Actor] = true
@@ -80,7 +81,7 @@ func calculateCheckSummary(events []Event, requiredChecks []string) *CheckSummar
 	// Events should be sorted chronologically, but we explicitly track timestamps to be safe
 	for i := range events {
 		e := &events[i]
-		if (e.Kind == "status_check" || e.Kind == "check_run") && e.Body != "" {
+		if (e.Kind == EventKindStatusCheck || e.Kind == EventKindCheckRun) && e.Body != "" {
 			existing, exists := latestChecks[e.Body]
 			// Update if:
 			// 1. First occurrence (!exists)
@@ -151,7 +152,7 @@ func calculateApprovalSummary(events []Event) *ApprovalSummary {
 
 	for i := range events {
 		e := &events[i]
-		if e.Kind == "review" && e.Outcome != "" {
+		if e.Kind == EventKindReview && e.Outcome != "" {
 			latestReviews[e.Actor] = *e
 		}
 	}

pkg/prx/events.go

@@ -4,6 +4,66 @@ import (
 	"time"
 )
 
+// Event kind constants for PR timeline events.
+const (
+	EventKindCommit        = "commit"         // EventKindCommit represents a commit event.
+	EventKindComment       = "comment"        // EventKindComment represents a comment event.
+	EventKindReview        = "review"         // EventKindReview represents a review event.
+	EventKindReviewComment = "review_comment" // EventKindReviewComment represents a review comment event.
+
+	EventKindLabeled   = "labeled"   // EventKindLabeled represents a label added event.
+	EventKindUnlabeled = "unlabeled" // EventKindUnlabeled represents a label removed event.
+
+	EventKindAssigned   = "assigned"   // EventKindAssigned represents an assignment event.
+	EventKindUnassigned = "unassigned" // EventKindUnassigned represents an unassignment event.
+
+	EventKindMilestoned   = "milestoned"   // EventKindMilestoned represents a milestone added event.
+	EventKindDemilestoned = "demilestoned" // EventKindDemilestoned represents a milestone removed event.
+
+	EventKindReviewRequested      = "review_requested"       // EventKindReviewRequested represents a review request event.
+	EventKindReviewRequestRemoved = "review_request_removed" // EventKindReviewRequestRemoved represents a review request removed event.
+
+	EventKindPRMerged       = "pr_merged"        // EventKindPRMerged represents a PR merge event.
+	EventKindReadyForReview = "ready_for_review" // EventKindReadyForReview represents a ready for review event.
+	EventKindConvertToDraft = "convert_to_draft" // EventKindConvertToDraft represents a convert to draft event.
+	EventKindClosed         = "closed"           // EventKindClosed represents a PR closed event.
+	EventKindReopened       = "reopened"         // EventKindReopened represents a PR reopened event.
+
+	EventKindMentioned  = "mentioned"  // EventKindMentioned represents a mention event.
+	EventKindReferenced = "referenced" // EventKindReferenced represents a reference event.
+
+	EventKindPinned      = "pinned"      // EventKindPinned represents a pin event.
+	EventKindUnpinned    = "unpinned"    // EventKindUnpinned represents an unpin event.
+	EventKindTransferred = "transferred" // EventKindTransferred represents a transfer event.
+
+	EventKindSubscribed   = "subscribed"   // EventKindSubscribed represents a subscription event.
+	EventKindUnsubscribed = "unsubscribed" // EventKindUnsubscribed represents an unsubscription event.
+
+	EventKindHeadRefDeleted     = "head_ref_deleted"      // EventKindHeadRefDeleted represents a head ref deletion event.
+	EventKindHeadRefRestored    = "head_ref_restored"     // EventKindHeadRefRestored represents a head ref restoration event.
+	EventKindHeadRefForcePushed = "head_ref_force_pushed" // EventKindHeadRefForcePushed represents a head ref force push event.
+
+	EventKindBaseRefChanged     = "base_ref_changed"      // EventKindBaseRefChanged represents a base ref change event.
+	EventKindBaseRefForcePushed = "base_ref_force_pushed" // EventKindBaseRefForcePushed represents a base ref force push event.
+
+	EventKindReviewDismissed = "review_dismissed" // EventKindReviewDismissed represents a review dismissed event.
+
+	EventKindLocked   = "locked"   // EventKindLocked represents a lock event.
+	EventKindUnlocked = "unlocked" // EventKindUnlocked represents an unlock event.
+
+	EventKindAutoMergeEnabled  = "auto_merge_enabled"  // EventKindAutoMergeEnabled represents an auto merge enabled event.
+	EventKindAutoMergeDisabled = "auto_merge_disabled" // EventKindAutoMergeDisabled represents an auto merge disabled event.
+
+	// EventKindDeploymentEnvironmentChanged represents a deployment environment change event.
+	EventKindDeploymentEnvironmentChanged = "deployment_environment_changed"
+
+	EventKindConnected    = "connected"    // EventKindConnected represents a connected event.
+	EventKindDisconnected = "disconnected" // EventKindDisconnected represents a disconnected event.
+
+	EventKindStatusCheck = "status_check" // EventKindStatusCheck represents a status check event (from APIs).
+	EventKindCheckRun    = "check_run"    // EventKindCheckRun represents a check run event (from APIs).
+)
+
 // WriteAccess constants for the Event.WriteAccess field.
 const (
 	WriteAccessNo         = -2 // User confirmed to not have write access

pkg/prx/graphql_complete.go

@@ -211,7 +211,7 @@ func (c *Client) convertGraphQLToEventsComplete(ctx context.Context, data *graph
 
 	for _, node := range data.Commits.Nodes {
 		event := Event{
-			Kind:        "commit",
+			Kind:        EventKindCommit,
 			Timestamp:   node.Commit.CommittedDate,
 			Body:        node.Commit.OID,
 			Description: truncate(node.Commit.Message),
@@ -235,7 +235,7 @@ func (c *Client) convertGraphQLToEventsComplete(ctx context.Context, data *graph
 			timestamp = *review.SubmittedAt
 		}
 		event := Event{
-			Kind:        "review",
+			Kind:        EventKindReview,
 			Timestamp:   timestamp,
 			Actor:       review.Author.Login,
 			Body:        truncate(review.Body),
@@ -252,7 +252,7 @@ func (c *Client) convertGraphQLToEventsComplete(ctx context.Context, data *graph
 		for j := range thread.Comments.Nodes {
 			comment := &thread.Comments.Nodes[j]
 			event := Event{
-				Kind:        "review_comment",
+				Kind:        EventKindReviewComment,
 				Timestamp:   comment.CreatedAt,
 				Actor:       comment.Author.Login,
 				Body:        truncate(comment.Body),
@@ -267,7 +267,7 @@ func (c *Client) convertGraphQLToEventsComplete(ctx context.Context, data *graph
 
 	for _, comment := range data.Comments.Nodes {
 		event := Event{
-			Kind:        "comment",
+			Kind:        EventKindComment,
 			Timestamp:   comment.CreatedAt,
 			Actor:       comment.Author.Login,
 			Body:        truncate(comment.Body),
@@ -297,7 +297,7 @@ func (c *Client) convertGraphQLToEventsComplete(ctx context.Context, data *graph
 
 				if node.StartedAt != nil {
 					events = append(events, Event{
-						Kind:        "check_run",
+						Kind:        EventKindCheckRun,
 						Timestamp:   *node.StartedAt,
 						Body:        node.Name,
 						Outcome:     strings.ToLower(node.Status),
@@ -308,7 +308,7 @@ func (c *Client) convertGraphQLToEventsComplete(ctx context.Context, data *graph
 
 				if node.CompletedAt != nil {
 					events = append(events, Event{
-						Kind:        "check_run",
+						Kind:        EventKindCheckRun,
 						Timestamp:   *node.CompletedAt,
 						Body:        node.Name,
 						Outcome:     strings.ToLower(node.Conclusion),
@@ -322,7 +322,7 @@ func (c *Client) convertGraphQLToEventsComplete(ctx context.Context, data *graph
 					continue
 				}
 				event := Event{
-					Kind:        "status_check",
+					Kind:        EventKindStatusCheck,
 					Timestamp:   *node.CreatedAt,
 					Outcome:     strings.ToLower(node.State),
 					Body:        node.Context,
@@ -354,7 +354,7 @@ func (c *Client) convertGraphQLToEventsComplete(ctx context.Context, data *graph
 		}
 		if data.MergedBy != nil {
 			event.Actor = data.MergedBy.Login
-			event.Kind = "pr_merged"
+			event.Kind = EventKindPRMerged
 			event.Bot = isBot(*data.MergedBy)
 		}
 		events = append(events, event)
@@ -420,51 +420,51 @@ func (*Client) parseGraphQLTimelineEvent(_ context.Context, item map[string]any,
 
 	switch typename {
 	case "AssignedEvent":
-		event.Kind = "assigned"
+		event.Kind = EventKindAssigned
 		if assignee, ok := item["assignee"].(map[string]any); ok {
 			if login, ok := assignee["login"].(string); ok {
 				event.Target = login
 			}
 		}
 
 	case "UnassignedEvent":
-		event.Kind = "unassigned"
+		event.Kind = EventKindUnassigned
 		if assignee, ok := item["assignee"].(map[string]any); ok {
 			if login, ok := assignee["login"].(string); ok {
 				event.Target = login
 			}
 		}
 
 	case "LabeledEvent":
-		event.Kind = "labeled"
+		event.Kind = EventKindLabeled
 		if label, ok := item["label"].(map[string]any); ok {
 			if name, ok := label["name"].(string); ok {
 				event.Target = name
 			}
 		}
 
 	case "UnlabeledEvent":
-		event.Kind = "unlabeled"
+		event.Kind = EventKindUnlabeled
 		if label, ok := item["label"].(map[string]any); ok {
 			if name, ok := label["name"].(string); ok {
 				event.Target = name
 			}
 		}
 
 	case "MilestonedEvent":
-		event.Kind = "milestoned"
+		event.Kind = EventKindMilestoned
 		if title, ok := item["milestoneTitle"].(string); ok {
 			event.Target = title
 		}
 
 	case "DemilestonedEvent":
-		event.Kind = "demilestoned"
+		event.Kind = EventKindDemilestoned
 		if title, ok := item["milestoneTitle"].(string); ok {
 			event.Target = title
 		}
 
 	case "ReviewRequestedEvent":
-		event.Kind = "review_requested"
+		event.Kind = EventKindReviewRequested
 		if reviewer, ok := item["requestedReviewer"].(map[string]any); ok {
 			if login, ok := reviewer["login"].(string); ok {
 				event.Target = login
@@ -474,7 +474,7 @@ func (*Client) parseGraphQLTimelineEvent(_ context.Context, item map[string]any,
 		}
 
 	case "ReviewRequestRemovedEvent":
-		event.Kind = "review_request_removed"
+		event.Kind = EventKindReviewRequestRemoved
 		if reviewer, ok := item["requestedReviewer"].(map[string]any); ok {
 			if login, ok := reviewer["login"].(string); ok {
 				event.Target = login
@@ -484,50 +484,50 @@ func (*Client) parseGraphQLTimelineEvent(_ context.Context, item map[string]any,
 		}
 
 	case "MentionedEvent":
-		event.Kind = "mentioned"
+		event.Kind = EventKindMentioned
 		event.Body = "User was mentioned"
 
 	case "ReadyForReviewEvent":
-		event.Kind = "ready_for_review"
+		event.Kind = EventKindReadyForReview
 
 	case "ConvertToDraftEvent":
-		event.Kind = "convert_to_draft"
+		event.Kind = EventKindConvertToDraft
 
 	case "ClosedEvent":
-		event.Kind = "closed"
+		event.Kind = EventKindClosed
 
 	case "ReopenedEvent":
-		event.Kind = "reopened"
+		event.Kind = EventKindReopened
 
 	case "MergedEvent":
 		event.Kind = "merged"
 
 	case "AutoMergeEnabledEvent":
-		event.Kind = "auto_merge_enabled"
+		event.Kind = EventKindAutoMergeEnabled
 
 	case "AutoMergeDisabledEvent":
-		event.Kind = "auto_merge_disabled"
+		event.Kind = EventKindAutoMergeDisabled
 
 	case "ReviewDismissedEvent":
-		event.Kind = "review_dismissed"
+		event.Kind = EventKindReviewDismissed
 		if msg, ok := item["dismissalMessage"].(string); ok {
 			event.Body = msg
 		}
 
 	case "BaseRefChangedEvent":
-		event.Kind = "base_ref_changed"
+		event.Kind = EventKindBaseRefChanged
 
 	case "BaseRefForcePushedEvent":
-		event.Kind = "base_ref_force_pushed"
+		event.Kind = EventKindBaseRefForcePushed
 
 	case "HeadRefForcePushedEvent":
-		event.Kind = "head_ref_force_pushed"
+		event.Kind = EventKindHeadRefForcePushed
 
 	case "HeadRefDeletedEvent":
-		event.Kind = "head_ref_deleted"
+		event.Kind = EventKindHeadRefDeleted
 
 	case "HeadRefRestoredEvent":
-		event.Kind = "head_ref_restored"
+		event.Kind = EventKindHeadRefRestored
 
 	case "RenamedTitleEvent":
 		event.Kind = "renamed_title"
@@ -538,10 +538,10 @@ func (*Client) parseGraphQLTimelineEvent(_ context.Context, item map[string]any,
 		}
 
 	case "LockedEvent":
-		event.Kind = "locked"
+		event.Kind = EventKindLocked
 
 	case "UnlockedEvent":
-		event.Kind = "unlocked"
+		event.Kind = EventKindUnlocked
 
 	case "AddedToMergeQueueEvent":
 		event.Kind = "added_to_merge_queue"
@@ -556,37 +556,37 @@ func (*Client) parseGraphQLTimelineEvent(_ context.Context, item map[string]any,
 		event.Kind = "automatic_base_change_failed"
 
 	case "ConnectedEvent":
-		event.Kind = "connected"
+		event.Kind = EventKindConnected
 
 	case "DisconnectedEvent":
-		event.Kind = "disconnected"
+		event.Kind = EventKindDisconnected
 
 	case "CrossReferencedEvent":
 		event.Kind = "cross_referenced"
 
 	case "ReferencedEvent":
-		event.Kind = "referenced"
+		event.Kind = EventKindReferenced
 
 	case "SubscribedEvent":
-		event.Kind = "subscribed"
+		event.Kind = EventKindSubscribed
 
 	case "UnsubscribedEvent":
-		event.Kind = "unsubscribed"
+		event.Kind = EventKindUnsubscribed
 
 	case "DeployedEvent":
 		event.Kind = "deployed"
 
 	case "DeploymentEnvironmentChangedEvent":
-		event.Kind = "deployment_environment_changed"
+		event.Kind = EventKindDeploymentEnvironmentChanged
 
 	case "PinnedEvent":
-		event.Kind = "pinned"
+		event.Kind = EventKindPinned
 
 	case "UnpinnedEvent":
-		event.Kind = "unpinned"
+		event.Kind = EventKindUnpinned
 
 	case "TransferredEvent":
-		event.Kind = "transferred"
+		event.Kind = EventKindTransferred
 
 	case "UserBlockedEvent":
 		event.Kind = "user_blocked"