bugfix/error_signing_redirect: Fixed code review comments

* Processed code review comments.

Author: AndreiToader-stanescu-TomTom

app/src/main/java/ro/code4/monitorizarevot/exceptions/RetrofitException.kt

@@ -10,7 +10,7 @@ import java.io.IOException
 /**
  * Exception that is retrieved from retrofit. It is of three types, http, network and unexpected.
  */
-open class RetrofitException internal constructor(
+class RetrofitException internal constructor(
     message: String?,
     /**
      * RobResponse object containing status code, headers, body, etc.

app/src/main/java/ro/code4/monitorizarevot/repositories/Repository.kt

@@ -260,13 +260,14 @@ class Repository : KoinComponent {
             .toObservable()
             .subscribeOn(Schedulers.io())
             .flatMap {
-                return@flatMap syncAnswers(it)
+                syncAnswers(it)
             }
             .map {
                 return@map it.successOrThrow()
             }
             .flatMap {
                 return@flatMap db.formDetailsDao()
+
                     .updateAnsweredQuestions(countyCode, pollingStationNumber, formId)
                     .andThen(Observable.just(it))
             }

app/src/main/java/ro/code4/monitorizarevot/ui/guide/GuideFragment.kt

@@ -71,10 +71,7 @@ class GuideFragment : BaseViewModelFragment<GuideViewModel>() {
                     description: String?,
                     failingUrl: String?
                 ) {
-                    var message: String? = description
-                    if (TextUtils.isEmpty(message)) {
-                        message = "Unknown Error"
-                    }
+                    val message = description.takeUnless { it.isNullOrEmpty() } ?: "Unknown Error"
                     onError(
                         WebViewException(
                             message!!,
@@ -91,15 +88,11 @@ class GuideFragment : BaseViewModelFragment<GuideViewModel>() {
 
     override fun onError(thr: Throwable) {
         logE(TAG, "Error loading the page:" + thr.message)
-        var messageId: String = getString(R.string.error_generic_message)
-        if (thr is WebViewException) {
-            if (thr.message.contains("ERR_INTERNET_DISCONNECTED")) {
-                messageId = getString(R.string.error_no_connection)
-            }
-        }
+        val messageId =
+            if (thr is WebViewException) R.string.error_no_connection else R.string.error_generic_message
 
         progressDialog.dismiss()
-        logE(TAG, messageId)
+        logE(TAG, getString(messageId))
         //todo add action
     }
 

app/src/main/java/ro/code4/monitorizarevot/ui/login/LoginActivity.kt

@@ -100,10 +100,8 @@ class LoginActivity : BaseAnalyticsActivity<LoginViewModel>() {
                         processHttpException(exception, fallback)
                     }
                     RetrofitException.Kind.NETWORK -> {
-                        var messageId: String = getString(R.string.error_generic)
-                        if (!isOnline()) {
-                            messageId = getString(R.string.login_no_internet)
-                        }
+                        val messageId =
+                            if (!isOnline()) R.string.login_no_internet else R.string.error_generic
 
                         Snackbar.make(
                             loginButton,