Skip to content

Commit 36c8d6d

Browse files
greenkeeper[bot]begedin
authored andcommitted
chore(package): update ember-keyboard to version 3.0.0 (#1693)
Switch tests related to modal close on escape to use ember-keyboard helpers
1 parent 1eaded1 commit 36c8d6d

File tree

4 files changed

+16
-8
lines changed

4 files changed

+16
-8
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
"ember-export-application-global": "^2.0.0",
7171
"ember-font-awesome": "^3.0.5",
7272
"ember-i18n": "^5.0.2",
73-
"ember-keyboard": "^2.3.0",
73+
"ember-keyboard": "^3.0.0",
7474
"ember-link-action": "^0.0.37",
7575
"ember-load": "^0.0.12",
7676
"ember-load-initializers": "^1.0.0",

tests/pages/components/github/repo-disconnect-confirm-modal.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
import { fillable, is, isVisible, triggerable } from 'ember-cli-page-object';
1+
import { fillable, is, isVisible } from 'ember-cli-page-object';
22
import { clickable } from 'code-corps-ember/tests/pages/helpers/clickable-native';
3+
import { triggerKeyDown } from 'ember-keyboard';
34

45
export default {
56
scope: '.github__repo-disconnect-confirm-modal',
@@ -19,7 +20,9 @@ export default {
1920
isDisabled: is(':disabled')
2021
},
2122

22-
hitEscape: triggerable('keydown', '', { eventProperties: { keyCode: 27 } }),
23+
hitEscape() {
24+
triggerKeyDown('Escape');
25+
},
2326

2427
input: {
2528
scope: 'input',

tests/pages/components/project-join-modal.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1-
import { isVisible, triggerable } from 'ember-cli-page-object';
1+
import { isVisible } from 'ember-cli-page-object';
22
import { clickable } from 'code-corps-ember/tests/pages/helpers/clickable-native';
33
import relatedSkills from 'code-corps-ember/tests/pages/components/related-skills';
4+
import { triggerKeyDown } from 'ember-keyboard';
45

56
export default {
67
scope: '.project-join-modal-container',
@@ -16,7 +17,11 @@ export default {
1617
joinProjectButton: {
1718
scope: 'button'
1819
},
19-
hitEscape: triggerable('keydown', '', { eventProperties: { keyCode: 27 } }),
20+
21+
hitEscape() {
22+
triggerKeyDown('Escape');
23+
},
24+
2025
relatedSkills
2126
},
2227

yarn.lock

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3407,9 +3407,9 @@ ember-k-codemod@^0.1.0:
34073407
glob "^7.1.1"
34083408
jscodeshift "^0.3.29"
34093409

3410-
ember-keyboard@^2.3.0:
3411-
version "2.3.0"
3412-
resolved "https://registry.yarnpkg.com/ember-keyboard/-/ember-keyboard-2.3.0.tgz#6a210ccfc3ad8ca19e73cbef291ed2a0afd08ad0"
3410+
ember-keyboard@^3.0.0:
3411+
version "3.0.0"
3412+
resolved "https://registry.yarnpkg.com/ember-keyboard/-/ember-keyboard-3.0.0.tgz#4f85ad4f8f91e54c4d646229fbb3aca6bcb4261f"
34133413
dependencies:
34143414
ember-cli-babel "^6.8.2"
34153415

0 commit comments

Comments
 (0)