Test outcomes on IssueComment event on normal issues

Author: begedin

lib/code_corps/github/sync/sync.ex

@@ -267,9 +267,12 @@ defmodule CodeCorps.GitHub.Sync do
       {:error, :task, %Changeset{} = changeset, _steps} ->
         {:error, :validating_task, changeset}
 
-      {:error, :github_comment, %Changeset{} = changeset, _steps} ->
+      {:error, :github_comment, %Changeset{data: %GithubComment{}} = changeset, _steps} ->
         {:error, :validating_github_comment, changeset}
 
+      {:error, :github_comment, %Changeset{data: %GithubUser{}} = changeset, _steps} ->
+        {:error, :validating_github_user_on_github_comment, changeset}
+
       {:error, :comment_user, %Changeset{} = changeset, _steps} ->
         {:error, :validating_comment_user, changeset}
 

test/lib/code_corps/github/sync/sync_test.exs

@@ -106,7 +106,7 @@ defmodule CodeCorps.GitHub.SyncTest do
     end
   end
 
-  describe "issue_comment_event/1" do
+  describe "issue_comment_event/1 on comment created for pull request" do
     @issue_comment_preloads [
       :user,
       [task: :user],
@@ -115,7 +115,7 @@ defmodule CodeCorps.GitHub.SyncTest do
 
     @payload load_event_fixture("issue_comment_created_on_pull_request")
 
-    test "syncs correctly when comment created for a pull request" do
+    test "syncs correctly" do
       %{
         "issue" => %{
           "body" => issue_body,
@@ -392,8 +392,12 @@ defmodule CodeCorps.GitHub.SyncTest do
       assert {:error, :multiple_comment_users_match} ==
         @payload |> Sync.issue_comment_event()
     end
+  end
+
+  describe "issue_comment_event/1 on comment created for regular issue" do
+    @payload load_event_fixture("issue_comment_created")
 
-    test "syncs correctly when comment created for pull request" do
+    test "syncs correctly" do
       %{
         "issue" => %{
           "body" => issue_body,
@@ -413,14 +417,14 @@ defmodule CodeCorps.GitHub.SyncTest do
         "repository" => %{
           "id" => repo_github_id
         }
-      } = payload = load_event_fixture("issue_comment_created")
+      } = @payload
 
       project = insert(:project)
       insert(:github_repo, github_id: repo_github_id, project: project)
       insert(:task_list, project: project, done: true)
       insert(:task_list, project: project, inbox: true)
 
-      {:ok, comment} = Sync.issue_comment_event(payload)
+      {:ok, comment} = Sync.issue_comment_event(@payload)
 
       assert Repo.aggregate(GithubComment, :count, :id) == 1
       assert Repo.aggregate(GithubIssue, :count, :id) == 1
@@ -460,7 +464,152 @@ defmodule CodeCorps.GitHub.SyncTest do
       assert comment.user.github_id == comment_user_github_id
     end
 
-    test "syncs correctly on comment deleted" do
+    test "can fail when finding repo" do
+      assert {:error, :repo_not_found} == @payload |> Sync.issue_comment_event()
+    end
+
+    test "can fail on github issue validation" do
+      insert(:github_repo, github_id: @payload["repository"]["id"])
+      assert {:error, :validating_github_issue, %Changeset{} = changeset} =
+        @payload
+        |> Kernel.put_in(["issue", "number"], nil)
+        |> Sync.issue_comment_event()
+
+      refute changeset.valid?
+    end
+
+    test "can fail on github user validation for github issue" do
+      insert(:github_repo, github_id: @payload["repository"]["id"])
+      assert {
+        :error,
+        :validating_github_user_on_github_issue,
+        %Changeset{} = changeset
+      } =
+        @payload
+        |> Kernel.put_in(["issue", "user", "login"], nil)
+        |> Sync.issue_comment_event()
+
+      refute changeset.valid?
+    end
+
+    test "can fail on task user validation" do
+      insert(:github_repo, github_id: @payload["repository"]["id"])
+
+      # setup data to trigger a unique constraint
+      email = "taken@mail.com"
+      insert(:user, email: email)
+      payload = @payload |> Kernel.put_in(["issue", "user", "email"], email)
+
+      assert {:error, :validating_task_user, %Changeset{} = changeset} =
+        payload |> Sync.issue_comment_event()
+
+      refute changeset.valid?
+    end
+
+    test "can fail if task matched with multiple users" do
+      github_repo =
+        insert(:github_repo, github_id: @payload["repository"]["id"])
+
+      attrs =
+        @payload["issue"]
+        |> Adapters.Issue.to_issue()
+        |> Map.put(:github_repo, github_repo)
+
+      github_issue = insert(:github_issue, attrs)
+      # creates a user for each task, which should never happen normally
+      insert_pair(:task, github_issue: github_issue)
+
+      assert {:error, :multiple_task_users_match} ==
+        @payload |> Sync.issue_comment_event()
+    end
+
+    test "can fail on task validation" do
+      insert(:github_repo, github_id: @payload["repository"]["id"])
+
+      # validation is triggered due to missing task list
+
+      assert {:error, :validating_task, %Changeset{} = changeset} =
+        @payload |> Sync.issue_comment_event()
+
+      refute changeset.valid?
+    end
+
+    test "can fail on github comment validation" do
+      %{project: project} =
+        insert(:github_repo, github_id: @payload["repository"]["id"])
+
+      insert(:task_list, project: project, done: true)
+      insert(:task_list, project: project, inbox: true)
+
+      assert {:error, :validating_github_comment, %Changeset{} = changeset} =
+        @payload
+        |> Kernel.put_in(["comment", "url"], nil)
+        |> Sync.issue_comment_event()
+
+      refute changeset.valid?
+    end
+
+    test "can fail on github user validation for github comment" do
+      %{project: project} =
+        insert(:github_repo, github_id: @payload["repository"]["id"])
+
+      insert(:task_list, project: project, done: true)
+      insert(:task_list, project: project, inbox: true)
+
+      assert {
+        :error,
+        :validating_github_user_on_github_comment,
+        %Changeset{} = changeset
+      } =
+        @payload
+        |> Kernel.put_in(["comment", "user", "login"], nil)
+        |> Sync.issue_comment_event()
+
+      refute changeset.valid?
+    end
+
+    test "can fail on comment user validation" do
+      %{project: project} =
+        insert(:github_repo, github_id: @payload["repository"]["id"])
+
+      insert(:task_list, project: project, done: true)
+      insert(:task_list, project: project, inbox: true)
+
+      # setup data to trigger a unique constraint
+      email = "taken@mail.com"
+      insert(:user, email: email)
+
+      assert {:error, :validating_comment_user, %Changeset{} = changeset} =
+        @payload
+        |> Kernel.put_in(["comment", "user", "email"], email)
+        |> Sync.issue_comment_event()
+
+      refute changeset.valid?
+    end
+
+    test "can fail if commment matched with multiple users" do
+      %{project: project} = github_repo =
+        insert(:github_repo, github_id: @payload["repository"]["id"])
+
+      insert(:task_list, project: project, done: true)
+      insert(:task_list, project: project, inbox: true)
+
+      attrs =
+        @payload["comment"]
+        |> Adapters.Comment.to_github_comment()
+        |> Map.put(:github_repo, github_repo)
+
+      github_comment = insert(:github_comment, attrs)
+      # creates a user for each comment, which should never happen normally
+      insert_pair(:comment, github_comment: github_comment)
+
+      assert {:error, :multiple_comment_users_match} ==
+        @payload |> Sync.issue_comment_event()
+    end
+  end
+
+  describe "issue_comment_event/1 on comment deleted" do
+    test "syncs correctly" do
       %{"comment" => %{"id" => github_id}} = payload =
         load_event_fixture("issue_comment_deleted")