Add GithubIssue controller and fix validation of body

Author: joshsmith

lib/code_corps/github/event/issue_comment.ex

@@ -66,7 +66,7 @@ defmodule CodeCorps.GitHub.Event.IssueComment do
   end
 
   @spec operational_multi(map) :: Multi.t
-  defp operational_multi(%{"action" => action, "issue" => issue_payload, "comment" => comment_payload} = payload) when action in ~w(created edited) do
+  defp operational_multi(%{"action" => action, "issue" => _, "comment" => _} = payload) when action in ~w(created edited) do
     Multi.new
     |> Multi.run(:repo, fn _ -> RepoFinder.find_repo(payload) end)
     |> Multi.run(:github_issue, fn %{repo: github_repo} -> github_repo |> link_issue(payload) end)

lib/code_corps/model/github_issue.ex

@@ -1,7 +1,6 @@
 defmodule CodeCorps.GithubIssue do
   use Ecto.Schema
   import Ecto.Changeset
-  alias CodeCorps.GithubIssue
 
   schema "github_issues" do
     field :body, :string
@@ -28,7 +27,7 @@ defmodule CodeCorps.GithubIssue do
   def changeset(struct, params) do
     struct
     |> cast(params, [:body, :closed_at, :comments_url, :events_url, :github_created_at, :github_id, :github_updated_at, :html_url, :labels_url, :locked, :number, :state, :title, :url])
-    |> validate_required([:body, :comments_url, :events_url, :github_created_at, :github_id, :github_updated_at, :html_url, :labels_url, :locked, :number, :state, :title, :url])
+    |> validate_required([:comments_url, :events_url, :github_created_at, :github_id, :github_updated_at, :html_url, :labels_url, :locked, :number, :state, :title, :url])
   end
 
   def create_changeset(struct, params) do

lib/code_corps_web/controllers/github_issue_controller.ex

@@ -0,0 +1,23 @@
+defmodule CodeCorpsWeb.GithubIssueController do
+  use CodeCorpsWeb, :controller
+
+  alias CodeCorps.{GithubIssue, Helpers.Query}
+
+  action_fallback CodeCorpsWeb.FallbackController
+  plug CodeCorpsWeb.Plug.DataToAttributes
+  plug CodeCorpsWeb.Plug.IdsToIntegers
+
+  @spec index(Conn.t, map) :: Conn.t
+  def index(%Conn{} = conn, %{} = params) do
+    with github_repos <- GithubIssue |> Query.id_filter(params) |> Repo.all do
+      conn |> render("index.json-api", data: github_repos)
+    end
+  end
+
+  @spec show(Conn.t, map) :: Conn.t
+  def show(%Conn{} = conn, %{"id" => id}) do
+    with %GithubIssue{} = github_repo <- GithubIssue |> Repo.get(id) do
+      conn |> render("show.json-api", data: github_repo)
+    end
+  end
+end

lib/code_corps_web/router.ex

@@ -107,6 +107,7 @@ defmodule CodeCorpsWeb.Router do
     resources "/comments", CommentController, only: [:index, :show]
     resources "/donation-goals", DonationGoalController, only: [:index, :show]
     resources "/github-app-installations", GithubAppInstallationController, only: [:index, :show]
+    resources "/github-issues", GithubIssueController, only: [:index, :show]
     resources "/github-repos", GithubRepoController, only: [:index, :show]
     resources "/organization-github-app-installations", OrganizationGithubAppInstallationController, only: [:index, :show]
     resources "/organizations", OrganizationController, only: [:index, :show]