Replace TaskList with jsonapi

Author: snewcomer

config/config.exs

@@ -87,6 +87,9 @@ config :code_corps, :processor, CodeCorps.Processor.Async
 
 config :code_corps, password_reset_timeout: 3600
 
+config :jsonapi,
+  remove_links: true
+
 # Import environment specific config. This must remain at the bottom
 # of this file so it overrides the configuration defined above.
 import_config "#{Mix.env}.exs"

lib/code_corps_web/controllers/task_list_controller.ex

@@ -3,6 +3,7 @@ defmodule CodeCorpsWeb.TaskListController do
   use CodeCorpsWeb, :controller
 
   alias CodeCorps.{Helpers.Query, TaskList}
+  alias CodeCorpsWeb.{TaskListView}
 
   action_fallback CodeCorpsWeb.FallbackController
   plug CodeCorpsWeb.Plug.DataToAttributes
@@ -18,13 +19,13 @@ defmodule CodeCorpsWeb.TaskListController do
       |> Repo.all()
       |> preload()
 
-    conn |> render("index.json-api", data: task_lists)
+    conn |> render(TaskListView, "index.json-api", %{data: task_lists, conn: conn})
   end
 
   @spec show(Conn.t, map) :: Conn.t
   def show(%Conn{} = conn, %{"id" => id}) do
     with %TaskList{} = task_list <- TaskList |> Repo.get(id) |> preload() do
-      conn |> render("show.json-api", data: task_list)
+      conn |> render(TaskListView, "show.json-api", %{data: task_list, conn: conn, params: id})
     end
   end
 

lib/code_corps_web/views/comment_view.ex

@@ -2,6 +2,7 @@ defmodule CodeCorpsWeb.CommentView do
   @moduledoc false
   use CodeCorpsWeb, :view
   use JaSerializer.PhoenixView
+  use JSONAPI.View, type: "comment"
 
   attributes [
     :body, :created_at, :created_from, :inserted_at, :markdown, :modified_at,

lib/code_corps_web/views/project_view.ex

@@ -5,6 +5,15 @@ defmodule CodeCorpsWeb.ProjectView do
 
   use CodeCorpsWeb, :view
   use JaSerializer.PhoenixView
+  use JSONAPI.View, type: "project"
+
+  def fields do
+    [:approved, :can_activate_donations, :cloudinary_public_id,
+    :description, :donations_active, :icon_thumb_url,
+    :icon_large_url, :inserted_at, :long_description_body,
+    :long_description_markdown, :should_link_externally, :slug, :title,
+    :total_monthly_donated, :updated_at, :website]
+  end
 
   attributes [
   	:approval_requested,

lib/code_corps_web/views/task_list_view.ex

@@ -1,11 +1,21 @@
 defmodule CodeCorpsWeb.TaskListView do
   @moduledoc false
   use CodeCorpsWeb, :view
-  use JaSerializer.PhoenixView
+  use JSONAPI.View, type: "task-list"
 
-  attributes [:done, :inbox, :name, :order, :pull_requests, :inserted_at, :updated_at]
+  alias CodeCorpsWeb.{ProjectView, TaskView}
 
-  has_one :project, type: "project", field: :project_id
+  def render("index.json-api", %{data: task_list, conn: conn}) do
+    __MODULE__.index(task_list, conn, nil)
+  end
 
-  has_many :tasks, serializer: CodeCorpsWeb.TaskView, identifiers: :always
+  def render("show.json-api", %{data: task_list, conn: conn, params: params}) do
+    __MODULE__.show(task_list, conn, params)
+  end
+
+  def fields, do: [:done, :inbox, :name, :order, :pull_requests, :inserted_at, :updated_at]
+
+  def relationships do
+    [project: ProjectView, tasks: TaskView]
+  end
 end

lib/code_corps_web/views/task_view.ex

@@ -1,39 +1,39 @@
 defmodule CodeCorpsWeb.TaskView do
   @moduledoc false
   use CodeCorpsWeb, :view
-  use JaSerializer.PhoenixView
+  use JSONAPI.View, type: "task"
 
-  attributes [
-    :archived, :body, :created_at, :created_from, :has_github_pull_request,
-    :inserted_at, :markdown, :modified_at, :modified_from, :number, :order,
-    :overall_status, :status, :title, :updated_at
-  ]
+  alias CodeCorpsWeb.{GithubIssueView, GithubPullRequestView, GithubRepoView, ProjectView,
+    TaskListView, UserView, UserTaskView, CommentView, TaskSkillView}
 
-  has_one :github_issue, type: "github-issue", field: :github_issue_id
-  has_one :github_pull_request, serializer: CodeCorpsWeb.GithubPullRequestView, identifiers: :always
-  has_one :github_repo, type: "github-repo", field: :github_repo_id
-  has_one :project, type: "project", field: :project_id
-  has_one :task_list, type: "task-list", field: :task_list_id
-  has_one :user, type: "user", field: :user_id
-  has_one :user_task, serializer: CodeCorpsWeb.UserTaskView, identifiers: :always
+  def fields do
+    [:archived, :body, :created_at, :created_from, :inserted_at, :markdown,
+    :modified_at, :modified_from, :number, :order, :status, :title, :updated_at]
+  end
 
-  has_many :comments, serializer: CodeCorpsWeb.CommentView, identifiers: :always
-  has_many :task_skills, serializer: CodeCorpsWeb.TaskSkillView, identifiers: :always
+  def relationships do
+    [comments: CommentView, task_skills: TaskSkillView]
+  end
 
-  def has_github_pull_request(%{
-    github_pull_request: %CodeCorps.GithubPullRequest{}
-  }), do: true
-  def has_github_pull_request(%{github_pull_request: nil}), do: false
+# <<<<<<< HEAD
+#   has_many :comments, serializer: CodeCorpsWeb.CommentView, identifiers: :always
+#   has_many :task_skills, serializer: CodeCorpsWeb.TaskSkillView, identifiers: :always
 
-  def overall_status(%{
-    github_pull_request: %CodeCorps.GithubPullRequest{merged: merged, state: state}
-  }, _conn) do
-    case merged do
-      true -> "merged"
-      false -> state
-    end
-  end
-  def overall_status(%{github_pull_request: nil, status: status}, _conn) do
-    status
-  end
+#   def has_github_pull_request(%{
+#     github_pull_request: %CodeCorps.GithubPullRequest{}
+#   }), do: true
+#   def has_github_pull_request(%{github_pull_request: nil}), do: false
+
+#   def overall_status(%{
+#     github_pull_request: %CodeCorps.GithubPullRequest{merged: merged, state: state}
+#   }, _conn) do
+#     case merged do
+#       true -> "merged"
+#       false -> state
+#     end
+#   end
+#   def overall_status(%{github_pull_request: nil, status: status}, _conn) do
+#     status
+#   end
+# =======
 end

mix.exs

@@ -72,6 +72,7 @@ defmodule CodeCorps.Mixfile do
       {:ja_serializer, "~> 0.12"}, # JSON API
       {:joken, "~> 1.5"}, # JWT encoding
       {:mix_test_watch, "~> 0.5", only: :dev, runtime: false},
+      {:jsonapi, git: "https://github.com/jeregrine/jsonapi.git"},
       {:money, "~> 1.2.1"},
       {:poison, "~> 3.0", override: true},
       {:scout_apm, "~> 0.0"},