Remove JaResouce and Canary

Author: landongrindheim

config/config.exs

@@ -38,10 +38,6 @@ config :guardian, Guardian,
   secret_key: System.get_env("GUARDIAN_SECRET_KEY"),
   serializer: CodeCorpsWeb.GuardianSerializer
 
-config :canary, repo: CodeCorps.Repo
-config :canary, unauthorized_handler: {CodeCorpsWeb.AuthenticationHelpers, :handle_unauthorized}
-config :canary, not_found_handler: {CodeCorpsWeb.AuthenticationHelpers, :handle_not_found}
-
 # Configures ex_aws with credentials
 config :ex_aws, :code_corps,
   access_key_id: [System.get_env("AWS_ACCESS_KEY_ID"), :instance_role],
@@ -86,9 +82,6 @@ config :sentry,
   included_environments: ~w(prod staging)a,
   use_error_logger: true
 
-config :ja_resource,
-  repo: CodeCorps.Repo
-
 # Import environment specific config. This must remain at the bottom
 # of this file so it overrides the configuration defined above.
 import_config "#{Mix.env}.exs"

lib/code_corps/policy/policy.ex

@@ -6,7 +6,6 @@ defmodule CodeCorps.Policy do
   alias CodeCorps.{Category, Comment, DonationGoal, GithubAppInstallation, Organization, OrganizationInvite, OrganizationGithubAppInstallation, Preview, Project, ProjectCategory, ProjectGithubRepo, ProjectSkill, ProjectUser, Role, RoleSkill, Skill, StripeConnectAccount, StripeConnectPlan, StripeConnectSubscription, StripePlatformCard, StripePlatformCustomer, Task, TaskSkill, User, UserCategory, UserRole, UserSkill, UserTask}
 
   alias CodeCorps.Policy
-  alias Ecto.Changeset
 
   @doc ~S"""
   Determines if the specified user can perform the specified action on the
@@ -90,19 +89,4 @@ defmodule CodeCorps.Policy do
   defp can?(%User{} = current_user, :show, %StripePlatformCustomer{} = stripe_platform_customer, %{}),
     do: Policy.StripePlatformCustomer.show?(current_user, stripe_platform_customer)
   defp can?(%User{} = user, :create, %GithubAppInstallation{}, %{} = params), do: Policy.GithubAppInstallation.create?(user, params)
-
-  defimpl Canada.Can, for: User do
-    # NOTE: Canary sets an :unauthorized and a :not_found handler on a config level
-    # The problem is, it will still go through the authorization process first and only call the
-    # not found handler after the unauthorized handler does its thing. This means that our
-    # unauthorized handler will halt the connection and respond, so the not_found handler
-    # will never do anything
-    #
-    # The only solution is to have a catch_all match for the resource being nil, which returns true
-
-    # NOTE: other tests are using the User policy for the time being.
-    def can?(%User{}, _action, nil), do: true
-
-    def can?(%User{} = user, :create, Role), do: Policy.Role.create?(user)
-  end
 end

lib/code_corps_web.ex

@@ -38,9 +38,6 @@ defmodule CodeCorpsWeb do
       import CodeCorpsWeb.Router.Helpers
       import CodeCorpsWeb.Gettext
 
-      import Canary.Plugs
-      import CodeCorpsWeb.AuthenticationHelpers, only: [load_and_authorize_changeset: 2]
-
       alias CodeCorps.{Repo, Policy}
       alias Plug.Conn
     end

lib/code_corps_web/helpers/authentication_helpers.ex

@@ -50,7 +50,6 @@ defmodule CodeCorps.Mixfile do
       {:cowboy, "~> 1.0"},
       {:benchfella, "~> 0.3.0", only: :dev},
       {:bypass, "~> 0.8.1", only: :test},
-      {:canary, "~> 1.1.1"}, # Authorization
       {:cloudex, "~> 0.1.17"},
       {:comeonin, "~> 3.1"},
       {:corsica, "~> 1.0"}, # CORS
@@ -65,7 +64,6 @@ defmodule CodeCorps.Mixfile do
       {:hackney, ">= 1.4.4"},
       {:inch_ex, "~> 0.5", only: [:dev, :test]}, # Inch CI
       {:inflex, "~> 1.8.1"},
-      {:ja_resource, "~> 0.2"},
       {:ja_serializer, "~> 0.12"}, # JSON API
       {:joken, "~> 1.5"}, # JWT encoding
       {:money, "~> 1.2.1"},