Added project filter in users index api (#1268)

Author: vishaldeepak

lib/code_corps/accounts/users.ex

@@ -0,0 +1,11 @@
+defmodule CodeCorps.Accounts.Users do
+  alias CodeCorps.ProjectUser
+
+  import Ecto.Query
+
+  def project_filter(query, %{"project_id" => project_id}) do
+    from user in query,
+      join: pu in ProjectUser, on: pu.user_id == user.id and pu.project_id == ^project_id
+  end
+  def project_filter(query, _), do: query
+end

lib/code_corps_web/controllers/user_controller.ex

@@ -7,7 +7,8 @@ defmodule CodeCorpsWeb.UserController do
     GitHub,
     Helpers.Query,
     Services.UserService,
-    User
+    User,
+    Accounts
   }
 
   action_fallback CodeCorpsWeb.FallbackController
@@ -20,6 +21,7 @@ defmodule CodeCorpsWeb.UserController do
       |> Query.id_filter(params)
       |> Query.limit_filter(params)
       |> Query.user_filter(params)
+      |> Accounts.Users.project_filter(params)
       |> Repo.all()
       |> preload()
 

test/lib/code_corps/accounts/users_test.exs

@@ -0,0 +1,28 @@
+defmodule CodeCorps.Accounts.UsersTest do
+  @moduledoc false
+
+  use CodeCorps.DbAccessCase
+  import CodeCorps.TestHelpers, only: [assert_ids_from_query: 2]
+
+  alias CodeCorps.{Accounts, User}
+
+  describe "project_filter/2" do
+    test "filters users by project filter" do
+      user_1 = insert(:user)
+      user_2 = insert(:user)
+
+      project = insert(:project)
+
+      insert(:project_user, user: user_1, project: project)
+      insert(:project_user, user: user_2, project: project)
+      insert(:project_user)
+
+      result =
+        User
+        |> Accounts.Users.project_filter(%{"project_id" => project.id})
+        |> Repo.all()
+
+      assert_ids_from_query(result, [user_1.id, user_2.id])
+     end
+  end
+end

test/lib/code_corps_web/controllers/user_controller_test.exs

@@ -62,6 +62,25 @@ defmodule CodeCorpsWeb.UserControllerTest do
       |> assert_ids_from_response([user_1.id, user_2.id, user_3.id])
     end
 
+    test "returns search result on project filter", %{conn: conn} do
+      user_1 = insert(:user)
+      user_2 = insert(:user)
+
+      project = insert(:project)
+
+      insert(:project_user, user: user_1, project: project)
+      insert(:project_user, user: user_2, project: project)
+      insert(:project_user)
+
+      params = %{"project_id" => project.id}
+      path = conn |> user_path(:index, params)
+
+      conn
+      |> get(path)
+      |> json_response(200)
+      |> assert_ids_from_response([user_1.id, user_2.id])
+    end
+
     test "limit filter limits results on index", %{conn: conn} do
       insert_list(6, :user)
 

test/support/test_helpers.ex

@@ -8,6 +8,10 @@ defmodule CodeCorps.TestHelpers do
     end
   end
 
+  def assert_ids_from_query(query, ids) do
+    assert query |> Enum.map(&Map.get(&1, :id)) |> Enum.sort == ids |> Enum.sort()
+  end
+
   def assert_id_from_response(response, id) do
     assert String.to_integer(response["data"]["id"]) == id
     response