fix: proper override for Column and Spatial

This is WIP and there is likely more to do. Hence
the reference #390.

Fixes the flaky test `PostGISTest#test_spatial_factory_attrs_parsing`

Author: BuonOmo

lib/active_record/connection_adapters/cockroachdb/column.rb

@@ -44,8 +44,7 @@ def initialize(name, cast_type, default, sql_type_metadata = nil, null = true,
             # @geometric_type = geo_type_from_sql_type(sql_type)
             build_from_sql_type(sql_type_metadata.sql_type)
           end
-          super(name, cast_type, default, sql_type_metadata, null, default_function,
-            collation: collation, comment: comment, serial: serial, generated: generated, identity: identity)
+
           if spatial? && @srid
             @limit = { srid: @srid, type: to_type_name(geometric_type) }
             @limit[:has_z] = true if @has_z
@@ -58,20 +57,18 @@ def initialize(name, cast_type, default, sql_type_metadata = nil, null = true,
                     :geometric_type,
                     :has_m,
                     :has_z,
-                    :srid
+                    :srid,
+                    :hidden
 
         alias geographic? geographic
         alias has_z? has_z
         alias has_m? has_m
+        alias hidden? hidden
 
         def limit
           spatial? ? @limit : super
         end
 
-        def hidden?
-          @hidden
-        end
-
         def spatial?
           %i[geometry geography].include?(@sql_type_metadata.type)
         end
@@ -80,6 +77,58 @@ def serial?
           default_function == 'unique_rowid()'
         end
 
+        # TODO: add tests (see #390)
+        def init_with(coder)
+          @geographic = coder["geographic"]
+          @geometric_type = coder["geometric_type"]
+          @has_m = coder["has_m"]
+          @has_z = coder["has_z"]
+          @srid = coder["srid"]
+          @hidden = coder["hidden"]
+          @limit = coder["limit"]
+          super
+        end
+
+        # TODO: add tests (see #390)
+        def encode_with(coder)
+          coder["geographic"] = @geographic
+          coder["geometric_type"] = @geometric_type
+          coder["has_m"] = @has_m
+          coder["has_z"] = @has_z
+          coder["srid"] = @srid
+          coder["hidden"] = @hidden
+          coder["limit"] = @limit
+          super
+        end
+
+        # TODO: add tests (see #390)
+        def ==(other)
+          other.is_a?(Column) &&
+            super &&
+            other.geographic == geographic &&
+            other.geometric_type == geometric_type &&
+            other.has_m == has_m &&
+            other.has_z == has_z &&
+            other.srid == srid &&
+            other.hidden == hidden &&
+            other.limit == limit
+
+        end
+        alias :eql? :==
+
+        # TODO: add tests (see #390)
+        def hash
+          Column.hash ^
+            super.hash ^
+            geographic.hash ^
+            geometric_type.hash ^
+            has_m.hash ^
+            has_z.hash ^
+            srid.hash ^
+            hidden.hash ^
+            limit.hash
+        end
+
         private
 
         def build_from_sql_type(sql_type)

lib/active_record/connection_adapters/cockroachdb/oid/spatial.rb

@@ -33,6 +33,7 @@ def initialize(oid, sql_type)
                 factory_attrs
               )
           end
+          protected attr_reader :sql_type, :spatial_factory
 
           # sql_type: geometry, geometry(Point), geometry(Point,4326), ...
           #
@@ -89,6 +90,19 @@ def serialize(value)
                                      .generate(geo_value)
           end
 
+          # TODO: add tests (see #390)
+          def ==(other)
+            super &&
+              @sql_type == other.sql_type
+              @spatial_factory == other.spatial_factory
+          end
+          alias eql? ==
+
+          # TODO: add tests (see #390)
+          def hash
+            super ^ [@sql_type, @spatial_factory].hash
+          end
+
           private
 
           def cast_value(value)

test/cases/adapters/postgresql/postgis_test.rb

@@ -104,7 +104,6 @@ def test_custom_factory
     object.save!
     object.reload
     assert_equal boundary.to_s, object.boundary.to_s
-    spatial_factory_store.clear
   end
 
   def test_spatial_factory_attrs_parsing