Skip to content
This repository was archived by the owner on Sep 27, 2019. It is now read-only.

Commit 93b44e1

Browse files
Add TODOs for catalog
1 parent 51d0512 commit 93b44e1

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

src/storage/data_table.cpp

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -934,6 +934,9 @@ void DataTable::AddTileGroupWithOidForRecovery(const oid_t &tile_group_id) {
934934
schemas.push_back(*schema);
935935
std::shared_ptr<const Layout> layout = nullptr;
936936

937+
// The TileGroup for recovery is always added in ROW layout,
938+
// This was a part of the previous design. If you are planning
939+
// to change this, make sure the layout is added to the catalog
937940
if (default_layout_->IsRowStore()) {
938941
layout = default_layout_;
939942
} else {
@@ -1366,7 +1369,9 @@ void DataTable::ClearIndexSamples() {
13661369
}
13671370

13681371
void DataTable::SetDefaultLayout(const column_map_type &column_map) {
1369-
default_layout_ = std::shared_ptr<const Layout>(new const Layout(column_map));
1372+
// TODO Pooja: Generate layout_oid_ and add it to the catalog
1373+
default_layout_ = std::shared_ptr<const Layout>(
1374+
new const Layout(column_map));
13701375
}
13711376

13721377
const Layout& DataTable::GetDefaultLayout() const {

src/storage/temp_table.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ oid_t TempTable::AddDefaultTileGroup() {
113113
TEMPTABLE_TILEGROUP_ID + static_cast<int>(tile_groups_.size());
114114

115115
// Create a tile group with that partitioning
116+
// Its a TempTable, so we don't need to make the Layout persistent
116117
std::shared_ptr<storage::TileGroup> tile_group(
117118
AbstractTable::GetTileGroupWithLayout(
118119
INVALID_OID, tile_group_id, default_layout_, TEMPTABLE_DEFAULT_SIZE));

0 commit comments

Comments
 (0)