Commit c561acb
# Which issue does this PR close?
- Part of apache#6736
- Closes apache#7941
- Closes apache#7965
# Rationale for this change
This is has a proposal for how to structure shredded `VariantArray`s and
the `variant_get` kernel
If people like the basic idea I will file some more tickets to track
additional follow on work
It is based on ideas ideas from @carpecodeum in
apache#7946 and @scovich in
apache#7915
I basically took the tests from
apache#7965 and the conversation with
@scovich recorded from
apache#7941 (comment)
and I bashed out how this might look
# What changes are included in this PR?
1. Update `VariantArray` to represent shredding
2. Add code to `variant_get` to support extracting paths as both
variants and typed fields
3. A pattern that I think can represent shredding and extraction
4. Tests for same
Note there are many things that are NOT in this PR that I envision doing
as follow on PRs:
1. Support and implementing `Path`s
2. Support for shredded objects
3. Support shredded lists
4. Support nested objects / lists
5. Full casting support
6. Support for other output types: `StringArray`, `StringViewArray`, etc
8. Many performance improvements
# Are these changes tested?
Yes
# Are there any user-facing changes?
New feature
---------
Co-authored-by: Samyak Sarnayak <samyak201@gmail.com>
Co-authored-by: Ryan Johnson <scovich@users.noreply.github.com>
1 parent 7a5f6d3 commit c561acb
File tree
10 files changed
+1104
-252
lines changed- parquet-variant-compute/src
- variant_get
- output
- parquet-variant/src
10 files changed
+1104
-252
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | | - | |
| 55 | + | |
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
72 | | - | |
73 | | - | |
| 72 | + | |
| 73 | + | |
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
18 | 38 | | |
19 | 39 | | |
20 | 40 | | |
21 | 41 | | |
22 | 42 | | |
23 | 43 | | |
24 | 44 | | |
25 | | - | |
| 45 | + | |
26 | 46 | | |
27 | 47 | | |
28 | 48 | | |
| |||
0 commit comments