Commit 8875504
authored
arrow-row: Document dictionary handling (apache#8168)
# Which issue does this PR close?
- related to apache#7627
- Related to apache#4811
# Rationale for this change
It was not clear to me what the expected behavior for round trip through
row converter was for DictionaryArrays, so let's document what @tustvold
says here:
apache#8067 (comment)
> I think the issue is that Datafusion is not handling the fact that row
encoding "hydrates" dictionaries. It should be updated to understand
that List<Dictionary<...>> will be converted to List<...>, much like it
already handles this for the non-nested case. Converting back to a
dictionary is expensive, and likely pointless, not to mention a breaking
change.
# What changes are included in this PR?
Document expected behavior with english comments and doc test
# Are these changes tested?
Yes (doctests)
# Are there any user-facing changes?
More docs, no behavior change1 parent ebb6ede commit 8875504
1 file changed
+33
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
100 | | - | |
| 100 | + | |
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
| |||
117 | 117 | | |
118 | 118 | | |
119 | 119 | | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
120 | 147 | | |
121 | 148 | | |
122 | 149 | | |
123 | 150 | | |
124 | 151 | | |
125 | 152 | | |
126 | 153 | | |
| 154 | + | |
127 | 155 | | |
128 | 156 | | |
129 | 157 | | |
| |||
661 | 689 | | |
662 | 690 | | |
663 | 691 | | |
| 692 | + | |
| 693 | + | |
664 | 694 | | |
665 | 695 | | |
666 | 696 | | |
| |||
768 | 798 | | |
769 | 799 | | |
770 | 800 | | |
| 801 | + | |
| 802 | + | |
771 | 803 | | |
772 | 804 | | |
773 | 805 | | |
| |||
0 commit comments