Skip to content

Commit e06ddcc

Browse files
ccoVeilleaauren
authored andcommitted
feat(test): use safecast.RequireConvert as a replacement for safecast.Convert in tests
1 parent 00b4619 commit e06ddcc

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

pkg/controllers/proxy/ipset_fixture_test.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -149,10 +149,7 @@ func buildIPVSServicesFromFixtures(t *testing.T, services *v1.ServiceList) []*ip
149149
require.GreaterOrEqualf(t, port.Port, int32(0), "service %s/%s has negative port %d", svc.Namespace, svc.Name, port.Port)
150150
const maxServicePort = 1<<16 - 1
151151
require.LessOrEqualf(t, port.Port, int32(maxServicePort), "service %s/%s port %d exceeds %d", svc.Namespace, svc.Name, port.Port, maxServicePort)
152-
targetPort, err := safecast.Convert[uint16](port.Port)
153-
if err != nil {
154-
t.Fatalf("failed to convert port %d to uint16: %v", port.Port, err)
155-
}
152+
targetPort := safecast.RequireConvert[uint16](t, port.Port)
156153

157154
appendService := func(ipStr string) {
158155
ip := net.ParseIP(ipStr)

0 commit comments

Comments
 (0)